In-Development TradeDangerous: power-user trade optimizer

Biteketkergetek

Biteketkergetek
gazelle said:
Thanks (I think). My decision for using the csv format and multiple files is based on the thought that it's easier for an "end-user" to understand (and I'm not that familiar with the json format).
Click to expand...

Yes, nice work indeed! Using a format directly usable by outsiders certainly makes sense. Even an external utility like mine could have been done using the csv idea, perhaps with metadata (table file names and sql) in additional file, and optional zip/unzip support which is easy with python.

My concern was being able to make updates easier, and I thought it is easier to share updates in a single file. What I haven't realized is that the updates (and conflicts) happens mostly in the System table, so there is no real need to have a single import/export file for everything.
 

Biteketkergetek

Biteketkergetek
kfsone said:
I'm mostly self-taught, and I solved the "knapsack-salesman" problem primarily by rubber-ducking it with my wife and sitting down with her and a bunch of monopoly money and cards and theory-crafting solutions.
Click to expand...

Is the knapsack-part optional? I remember that confused me a lot...

While that might be useful while funds are limited (and fun to implement :D), once enough funds are available (and one does not spend his money on a new shiny ship too early) it just makes the output more complex. This is very subjective, but I preferred to see a list of possible trade routes nearby (not necessarily including the one I'm currently in) to choose from, and make an informed decision based on this list, depending on factors:

  • route length
  • visited stations
  • age of price data
  • availability of alternative commodities (should the one planned run out)
  • current lunar phase or the mood I'm in :)
 
Last edited:

Smacker

Smacker
New World Order!

Please use these new formats for posting updates to TradeDangerous
(this replaces all the INSERT statements)

Note: everything now matches on names

Systems
---------
name,pos_x,pos_y,pos_z,AddedName,modified

e.g.
'26 Draconis',-39.0,24.90625,-0.65625,'Beta1','2014-08-26 15:22:38'

If you are unsure about the AddedName, use "Beta2"

Stations
---------
SystemName,name,ls_from_star

e.g.
'LHS 3262','Lacaille Prospect',759.0

If you don't know the station distance use 0.0
Currently we are only adding stations with markets, but that will change soon.
 

wolverine2710

Tutorial & Guide Writer
wolverine2710
RedWizard just posted this in the crowd source thread.. Its bedtime time for him now ;-)

Start of his post.
"I've just uploaded my confirmed set of 551 systems.
JSON files are here:
system.json: All system data, including crowdsourced distances.
distances.json: Crowdsourced distance data for systems I've recalculated. Mainly missing distance data from Harbinger (though that's in the other file). May be useful to someone who wants to run their own algorithm on it.

I'll take a look at the TD list tomorrow and generate inserts for any systems TD doesn't have.

I found some dupes in my data (that's why it's not 556) but there may be more - I'll do some more checking tomorrow. I expect there are around 30 stars missing now and some of them may be hiding in the lower precision data in JesusFreke's spreadsheet that I haven't used yet. There could also be some in TD that I don't have yet. So hopefully I'll be able to push the number a bit higher tomorrow."
End of his post.

In an hour Sierkje and her boyfriend are coming who stay this weekend. Looks as if I won't be able to post (a lot) any more - so you all get some rest that way ;->

I'm sure the data can be put to good use!!
Hopefully this data will end up in TD in due time....
 
Last edited:

Harbinger

Volunteer Moderator
Harbinger
I've imported RedWizzard's additions/fixes into my own data/Systems.csv.

There are 62 additional stars plus several name fixes (zeros used instead of the letter "O" in some of the Wredguia systems etc.) I also corrected the position of SOL in the file as it should be at exactly 0,0,0 and not a calculated position.

As the changes are not just a simple addition I'm instead including a link to the modified csv file.
 

Biteketkergetek

Biteketkergetek
Harbinger said:
There are 62 additional stars plus several name fixes (zeros used instead of the letter "O" in some of the Wredguia systems etc.) I also corrected the position of SOL in the file as it should be at exactly 0,0,0 and not a calculated position.
Click to expand...

Ouch, Sol should be at 0,0,0 for sure. Thanks for your work!

I am surprised that you wrote "SOL", though. At least in the CSV it is spelled correctly. :D
 

Harbinger

Volunteer Moderator
Harbinger
Biteketkergetek said:
Ouch, Sol should be at 0,0,0 for sure. Thanks for your work!

I am surprised that you wrote "SOL", though. At least in the CSV it is spelled correctly. :D
Click to expand...

There's no difference in the spelling of SOL and Sol.

I think you're confusing spelling with usage of upper/lower case.
 

ShadowGar

Banned
ShadowGar
Harbinger said:
I've imported RedWizzard's additions/fixes into my own data/Systems.csv.

There are 62 additional stars plus several name fixes (zeros used instead of the letter "O" in some of the Wredguia systems etc.) I also corrected the position of SOL in the file as it should be at exactly 0,0,0 and not a calculated position.

As the changes are not just a simple addition I'm instead including a link to the modified csv file.
Click to expand...

Were these changes submitted to trade dangerous with a ticket? I just want to make sure we get the same fixes in. When you hand out your own cvs file, it is a little hard now for someone to go through all 551 systems to find what you fixed.
And with the database still being worked on, your cvs file won't match the current work. So if you were to update soon, all your work may be erased.
 

Smacker

Smacker
Harbinger said:
I've imported RedWizzard's additions/fixes into my own data/Systems.csv.

There are 62 additional stars plus several name fixes (zeros used instead of the letter "O" in some of the Wredguia systems etc.) I also corrected the position of SOL in the file as it should be at exactly 0,0,0 and not a calculated position.

As the changes are not just a simple addition I'm instead including a link to the modified csv file.
Click to expand...
Thanks, I have updated to these. Spotted a least one rogue zero that should be an O (WREDGUIA BT-0 B47-0). Also should be RedWizzard not RedWizard (my original mistake)

I make it 539 Systems
 

wolverine2710

Tutorial & Guide Writer
wolverine2710
Smacker said:
Thanks, I have updated to these. Spotted a least one rogue zero that should be an O (WREDGUIA BT-0 B47-0). Also should be RedWizzard not RedWizard (my original mistake)

I make it 539 Systems
Click to expand...

If I'm not mistaken Smacker is the same as Sam MacKrill. I've checked TOTR (The One True Repository) and saw your pull request. Checked the systems.csv file and I see that there are 551 entries in it. Curious how you come to "I make it 539 Systems" ?

Note: RedWizzard before he went to bed yesterday has checked the misc sources. His "confirmed" list (which can be found here) (which you use ad reference I think also has 551 coords. Or do you mean 539 coords in the current pill. Source is your post.
 

wolverine2710

Tutorial & Guide Writer
wolverine2710
Sam Mackrill (Smacker) and Bernd Gollesch (cmdr name unknown) you both made a pull request. I've checked ONLY the systems.csv file as this one is directly related to the crowdsourcing effort. Bernd wrote in his pull request:
I've calculated some new systems with the combination of all the posted distances. For this I made a new Added category "Test-Combined" because it's based on all data.I also added a new station posted by SelectThis and sorted the list by Systemname, Stationname.
Click to expand...

Sam's list is newer and has 551 entries, Bernd's list has 543 entries. Sam's list has the same number of entries as the list by RedWizzard which in the crowd sourcing effort is taken as the reference. That list contains all "confirmed" coords by RedWizzard. He has used most data available. I can imagine that kfsone does not know what to merge into TD. In Bernd's list the addName is also Test-Combined.

Can you both perhaps have a talk to each other so that we can have both systems.csv file in sync?

Edit: Created an issue for it on the kfsone master.
 
Last edited:

wolverine2710

Tutorial & Guide Writer
wolverine2710
ShadowGar said:
Were these changes submitted to trade dangerous with a ticket? I just want to make sure we get the same fixes in. When you hand out your own cvs file, it is a little hard now for someone to go through all 551 systems to find what you fixed.
And with the database still being worked on, your cvs file won't match the current work. So if you were to update soon, all your work may be erased.
Click to expand...

Can't find an issue ticket for it. His list is based on the what I like to call the reference list by RedWizzard. It has the same amount of entries but has some fixes it seems.

Syncing all the different files and the one in TD is becoming a real challenge. I hope RedWizzard can change his reference file. Also Bernd and Sam (Smacker) probably have to change systems.csv file in their pull request.

Hopefully in a few days everything is stable and all is in sync.
 

Smacker

Smacker
wolverine2710 said:
If I'm not mistaken Smacker is the same as Sam MacKrill. I've checked TOTR (The One True Repository) and saw your pull request. Checked the systems.csv file and I see that there are 551 entries in it. Curious how you come to "I make it 539 Systems" ?
Click to expand...
Well done Sherlock, you found me!. Sam MACKRill :) all you need is an E. I am only counting systems in the Pill as that is what we have a final figure for. There are currently 12 systems in the list outside the Pill.
 

Smacker

Smacker
wolverine2710 said:
Sam Mackrill (Smacker) and Bernd Gollesch (cmdr name unknown) you both made a pull request. I've checked ONLY the systems.csv file as this one is directly related to the crowdsourcing effort. Bernd wrote in his pull request:

Sam's list is newer and has 551 entries, Bernd's list has 543 entries. Sam's list has the same number of entries as the list by RedWizzard which in the crowd sourcing effort is taken as the reference. That list contains all "confirmed" coords by RedWizzard. He has used most data available. I can imagine that kfsone does not know what to merge into TD. In Bernd's list the addName is also Test-Combined.

Can you both perhaps have a talk to each other so that we can have both systems.csv file in sync?

Edit: Created an issue for it on the kfsone master.
Click to expand...
Will do.
 

wolverine2710

Tutorial & Guide Writer
wolverine2710
Smacker said:
Bernd and I have been syncing our changes, I have also checked all the systems for spelling and coordinates. Should be the best yet. Count in the Pill = 563. Plot HERE
Click to expand...

Commanders you are wonderful. Even better if I interpreted my crowd source thread correctly is that you have also synced it with THE reference list provided by RedWizzard. Again perfect.

Checked the sytems.csv file in both (smacker, Bernd) your pull requests
Smacker: 574 lines - including header line.
Bernd: 544 lines - including header line.

That seems to indicate to me the files are NOT in sync.

Bad a math. Your file has 574 lines. Minus header is 573. You said (or read somewhere) There are 12 3D coords outside the pill -courtesy of FD. 573-12= 561. When including Sol in the systems.csv file (after all is THE reference point for the ED Universe) I end up with 562 instead of 563. Can you explain to me what I'm doing wrong?

Suggestions:

  1. Let the sytems.csv file reflect only our current bubble/pill/what ever form it has. Include Sol as an extra. Can be excluded easily by any author interested in the systems data. That way consumers (authors of tools) don't have to remove the 11 systems.
  2. It would of course be a waste to loose the coordinates provided by FD. Perhaps a "outside_reachable_pill_supplied_by_FD.txt" file (or something like that) could be created in TD's data directory. Aside from comments it can be in the current systems.csv format. That case IF the pill is expanded in SB3/SB4 and they are then in the bubble/pill we can add them easily to the systems.csv file.
 
You must log in or register to reply here.
Back
Top Bottom