My next attempt to make it survive is messing with "permissions"
[EDIT] Will have to wait for next update. Yes does look like fault in normal launcher(update)
Last edited:
Community Event / Creation TradeDangerous GUI front end
- Thread starter WombatFromHell
- Start date
My next attempt to make it survive is messing with "permissions"
[EDIT] Will have to wait for next update. Yes does look like fault in normal launcher(update)
Version 1.0.7.4 is rolling out now and should fix that really annoying fatal exception error when deleting the last row of the Pilot's Log. This release also includes fixes for that other set of annoying bugs that kept sorting the recent systems list in weird ways.
Enjoy.
Enjoy.
Straight FD launcher here. I will check and do a Reinstall of it later today and see what happens on the next one. It had survived the last 2 updates so I am sure something has changed.
Version 1.0.7.4 is rolling out now and should fix that really annoying fatal exception error when deleting the last row of the Pilot's Log. This release also includes fixes for that other set of annoying bugs that kept sorting the recent systems list in weird ways.
Enjoy.
Thanks again for continued updates and such a handy tool. +REP(soon as i can)
Still a few issues with the dropdown list, seems to get entries from random places in my flight log, will post a bug report on bitbucket with some pics.
Seems to be worse if I remove TDHelper.db and re-load. Will do more tests over next few days and post what I find.
Interesting, I thought I had tested the sorting fix pretty thoroughly, and I even used several different sets of logs. I suppose there is one way that the sorting might still behave strangely; if the user deletes entries from the Pilot's Log, then restarts TDHelper.
Basically, I'm using an optimization where after the Pilot's Log is populated TDHelper then uses it to speed up parsing the log files. So if you delete entries from it then restart, it will take the order and add the contents of the most recent netLog.
Using the database is a massive performance enhancement when working with many netLogs. My testing showed an improvement from about a 2 minute startup (with 336 entries), down to about 1.8 seconds.
I'll spend a little more time to see if I can find a balance between performance and accuracy when bootstrapping from the database to update recent systems.
Hadn't used the option to delete entries from the log - just deleted the TDHelper.db file and reloaded, gets a lot more messy doing that.
not had much time to get on pc today. but this is what i have noticed so far:
- - -
On first loading with original TDHelper.db I noticed a few messed up entries (have screenshot of this and backup db file)
if i then quit and reload without doing anything then the list gets all messed up. (Will have a few more screenshots of this tomorrow)
If i then Delete TDHelper.db and load then dropdown list gets populated from many different dates (not in any order) (screenshots tomorrow)
- Curious are you picking the list of items to display in the dropdown from the log files or from the database file - the pilots log database is always 100% accurate now.
Should have some free time tomoz to do some proper testing of this and post a report on bitbucket.
Did notice a speed increase in the latest version. Seems to be pretty quick dunno if that is anything to do with everything installed on SSD (you get used to stuff being faster - cant use my brothers pc is mega slow compared)
Last edited:
It's both, actually. I use the log files initially to populate both the recents list and then database (inside the same loop for efficiency), then upon subsequent restarts I use the database as well as the most recent netLog to populate the recents. Ctrl+Click'ing the C button overrides this and assumes we need to feed the database and dropdowns directly from their respective sources.
I'll do some more testing to see if I can pinpoint any obvious causes for why you might be having trouble with sorting in the recents dropdown.
(Edit: After thinking about it a little more, there could be one reason you're seeing "messed up" entries. By that, I assume you mean entries in the wrong order. I think the reason could be that when TDHelper uses the database to populate the recents list, it takes the entries from the database sorted by time (newest->oldest), removes any duplicates, then adds the most recent netLog. Those two steps of pulling newest->oldest then removing duplicates could be causing the sorting issue. I'll withhold jumping to conclusions until I can either reproduce it or I get a look at some screenshots to see whether or not that's the case.)
Last edited:
Part one of my testing with a theory is up on bitbucket
Will start the second bugtest now "Deleting TDHelper.db" this one gets even stranger than working with the original TDHelper.db so may take me a while
[Edit] tests done files attached on bitbucket over to you: (I wouldn't consider this a bug that needs a fast fix as the program works fine) its just a bit of a mismatch doesn't affect the usefulness of the tool.
Will start the second bugtest now "Deleting TDHelper.db" this one gets even stranger than working with the original TDHelper.db so may take me a while
[Edit] tests done files attached on bitbucket over to you: (I wouldn't consider this a bug that needs a fast fix as the program works fine) its just a bit of a mismatch doesn't affect the usefulness of the tool.
Last edited:
Part one of my testing with a theory is up on bitbucket
Will start the second bugtest now "Deleting TDHelper.db" this one gets even stranger than working with the original TDHelper.db so may take me a while
[Edit] tests done files attached on bitbucket over to you: (I wouldn't consider this a bug that needs a fast fix as the program works fine) its just a bit of a mismatch doesn't affect the usefulness of the tool.
As you mentioned in your issue ticket: the problem is related to the written timestamp of each log file. I'll see what I can do to improve that behavior for the next version. I may put up a hotfix in the issue ticket if I need some additional testing.
It did look like that at first, but the issue also has a mismatch that seems to point more towards ED losing server connections and possibly messing the recent list up in some way (highlighted in the Test2.rar) as the date does match with when the servers were playing up over the past weekend and i haven't adjusted any of the time-stamps on those files.
[EDIT]
Defiantly another headscratcher but something i can live with if this issue is only affecting me. will have to see if anyone else is having similar issues.
Last edited:
Version 1.0.7.5 is up; I was forced to rewrite the methods that fed the recent systems list in order to fix lingering bugs that crept in after I implemented the Pilot's Log. This also includes a fix for some improper behavior when using "Force Prices" with the "Skip prices" checkbox. See the changelog for details.
Just had an abnormally productive Monday. So, v1.0.7.6 is rolling out now with lots of stability, performance, and bug fixes. See the changelog for more details.
Cheers.
Cheers.
Have you tried running the command from a prompt outside of TDHelper? It looks like it might be a bug in TD itself. Maybe try reinstalling TD and see if it still happens?
ThanksJust had an abnormally productive Monday. So, v1.0.7.6 is rolling out now with lots of stability, performance, and bug fixes. See the changelog for more details.
Cheers.
Do you have a screen-grab of the TDhelper window for when you are executing these command it may help in finding the problem.
[edit] on looking at the outputs you are getting they look normal to me based on your Laden/UnLaden entries?
Last edited:
I'm still having an issue with TDH not showing the system I am currently in when I click current. Nor does the list update when I control-click. The last 2 versions have had this issue. Verbose logging is enabled as the list is populating, and the EDAPI import is getting the system/station right. It is always showing the last system I was in.
i have even removed all net logs and restarted the client. I make a few jumps to see the list is adding the systems, but never the current.
Any ideas?
i have even removed all net logs and restarted the client. I make a few jumps to see the list is adding the systems, but never the current.
Any ideas?
I think i just posted an issue for this on bitbucket, it seems to be happening if the system you enter is already in the recent dropdown list. can you confirm?
Confirmed. The pilot log shows the proper system at the top of the list. Even if I Ctrl-click to reload it still does not pick up the system.
Hmm, I thought I had fixed that one. I'll look into it. Thanks for bringing it to my attention.
I'm having some difficulty reproducing this. I've detailed the steps I've tried on the issue tracker #159. The snippet of code that controls what systems get added is as follows:
Code:
if (output.Count == 0 && !curSystem.Equals(lastEntry) && !curSystem.Equals(firstEntry)
|| !curSystem.Equals(lastEntry) && !curSystem.Equals(firstEntry))
output.Insert(0, curSystem);The intended behavior is to only add a system name if it isn't a duplicate (this is to avoid using Distinct() which can cause sorting issues in specific situations). If I had to guess, it would seem that checking against the first/last entry from the current netLog is what might be causing the problem.
I've attached a test binary to the issue ticket I linked above that should help with this behavior. If this issue affects anyone reading this, you might try using that binary and let me know if it solves it.