Abandoned [RELEASE] Trade Computer Extension

Status
Thread Closed: Not open for further replies.
Hi Eventure

Great looking tool, however can you talk me through deleting all the station price information that comes with the bundle? I'd like to only show data I've entered myself.
 
Hi Eventure

Great looking tool, however can you talk me through deleting all the station price information that comes with the bundle? I'd like to only show data I've entered myself.

I can tell you today, in the next version, which i release tomorrow, TCE can handle an empty database. So you can start with no entry (of stations and prices) and build it up only with your own data input.

With the current version i can tell you the following:
Gather data from two stations near you, then create a new database (click the checkbox) through importing (Option panel) your actual and selecting only your previously entered stations.
 
Last edited:
Got an error just now, previewing a trade route.

Run-time Error 13
Type mismatch

Public Sub POS_Display()


Dim txt1 As String, txt2 As String, txt3 As String, txt4 As String
Dim iName1 As Variant, iName2 As Variant, iName3 As Variant, iName4 As Variant
Dim x As Long, i As Long, z As Long

txt1 = "POS_Install"
x = 0

If Worksheets("Werte").Cells(6, 5).Value = 0 Then
Panel_Trade.POS_Image.Picture = LoadPicture("")
Else
Panel_Trade.POS_Image.Picture = LoadPicture(AppPath & "\JPG\" & Worksheets("Werte").Cells(6, 5).Value & ".jpg")
End If
Panel_Trade.POS_System.Caption = UCase(Worksheets("Werte").Cells(4, 2).Text) & " : " & UCase(Worksheets("Werte").Cells(5, 2).Text)
Panel_Trade.POS_Pad.Caption = "UNKNOWN"
If Worksheets("Werte").Cells(3, 8).Text = "S" Then
Panel_Trade.POS_Pad.Caption = "SMALL"
End If
If Worksheets("Werte").Cells(3, 8).Text = "M" Then
Panel_Trade.POS_Pad.Caption = "MEDIUM"
End If
If Worksheets("Werte").Cells(3, 8).Text = "L" Then
Panel_Trade.POS_Pad.Caption = "LARGE"
End If
Panel_Trade.POS_Stationtype.Caption = UCase(Worksheets("Werte").Cells(6, 6).Text)
Panel_Trade.POS_Juris.Caption = UCase(Worksheets("Werte").Cells(6, 2).Text)
Panel_Trade.POS_Eco.Caption = UCase(Worksheets("Werte").Cells(7, 2).Text)
If Worksheets("Data").Cells(76, 3).Value = 0 Then
Panel_Trade.POS_Distance.Caption = Worksheets("Werte").Cells(7, 5).Text & " LS"
Else
Panel_Trade.POS_Distance.Caption = Worksheets("Data").Cells(76, 3).Text & " LY / " & Worksheets("Werte").Cells(7, 5).Text & " LS"
End If
If Worksheets("Werte").Cells(10, 2).Value = 0 Then
Panel_Trade.POS_Date.Caption = "NEVER"
Else
Panel_Trade.POS_Date.Caption = UCase(Worksheets("Werte").Cells(10, 2).Text) & " - " & UCase(Worksheets("Werte").Cells(10, 3).Text)
End If
If Worksheets("Werte").Cells(8, 5).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# REFUELING"
End If
If Worksheets("Werte").Cells(9, 5).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# REARMING"
End If
If Worksheets("Werte").Cells(2, 8).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# REPAIR"
End If
If Worksheets("Werte").Cells(9, 2).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# BLACKMARKET"
End If
If Worksheets("Werte").Cells(10, 5).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# OUTFITTING"
End If
If Worksheets("Werte").Cells(8, 2).Value = 1 Then
x = x + 1
iName1 = txt1 & x
Panel_Trade.Controls(iName1).Caption = "# SHIPYARD"
End If
For i = x + 1 To 6
iName1 = txt1 & i
Panel_Trade.Controls(iName1).Caption = ""
Next i

txt1 = "POS_Ex"
txt2 = "POS_Discount"

For z = 1 To 6 Step 1
iName1 = txt1 & z
iName2 = txt2 & z
iName3 = txt2 & z & "P"
If Worksheets("POS_Export").Cells(z + 1, 1).Value <> "" Then
Panel_Trade.Controls(iName1).Caption = UCase(Worksheets("POS_Export").Cells(z + 1, 1).Text)
Panel_Trade.Controls(iName1).Visible = True
Panel_Trade.Controls(iName2).Caption = Worksheets("POS_Export").Cells(z + 1, 2).Text & " CR."
Panel_Trade.Controls(iName2).Visible = True
If Worksheets("POS_Export").Cells(z + 1, 3).Value > 0 Then
Panel_Trade.Controls(iName3).Caption = "+" & Worksheets("POS_Export").Cells(z + 1, 3).Text & " CR."
Else
Panel_Trade.Controls(iName3).Caption = Worksheets("POS_Export").Cells(z + 1, 3).Text & " CR."
End If
Panel_Trade.Controls(iName3).Visible = True
Else
Panel_Trade.Controls(iName1).Visible = False
Panel_Trade.Controls(iName2).Visible = False
Panel_Trade.Controls(iName3).Visible = False
End If
Next z
txt1 = "POS_Im"
txt2 = "POS_Profit"
For z = 1 To 6 Step 1
iName1 = txt1 & z
iName2 = txt2 & z
iName3 = txt2 & z & "P"
If Worksheets("POS_Import").Cells(z + 1, 1).Value <> "" Then
Panel_Trade.Controls(iName1).Caption = UCase(Worksheets("POS_Import").Cells(z + 1, 1).Text)
Panel_Trade.Controls(iName1).Visible = True
Panel_Trade.Controls(iName2).Caption = Worksheets("POS_Import").Cells(z + 1, 2).Text & " CR."
Panel_Trade.Controls(iName2).Visible = True
If Worksheets("POS_Import").Cells(z + 1, 3).Value > 0 Then
Panel_Trade.Controls(iName3).Caption = "+" & Worksheets("POS_Import").Cells(z + 1, 3).Text & " CR."
Else
Panel_Trade.Controls(iName3).Caption = Worksheets("POS_Import").Cells(z + 1, 3).Text & " CR."
End If
Panel_Trade.Controls(iName3).Visible = True
Else
Panel_Trade.Controls(iName1).Visible = False
Panel_Trade.Controls(iName2).Visible = False
Panel_Trade.Controls(iName3).Visible = False
End If
Next z

If Worksheets("Werte").Cells(3, 5).Value > 6 Then
Panel_Trade.POS_SB_Export.Max = Worksheets("Werte").Cells(3, 5).Value - 6
Panel_Trade.POS_SB_Export.Value = 0
Panel_Trade.POS_SB_Export.Visible = True
Else
Panel_Trade.POS_SB_Export.Visible = False
Panel_Trade.POS_SB_Export.Max = 0
Panel_Trade.POS_SB_Export.Value = 0
Panel_Trade.POS_SB_Export.Visible = True
End If
If Worksheets("Werte").Cells(3, 6).Value > 6 Then
Panel_Trade.POS_SB_Import.Max = Worksheets("Werte").Cells(3, 6).Value - 6
Panel_Trade.POS_SB_Import.Value = 0
Panel_Trade.POS_SB_Import.Visible = True
Else
Panel_Trade.POS_SB_Import.Visible = False
Panel_Trade.POS_SB_Import.Max = 0
Panel_Trade.POS_SB_Import.Value = 0
Panel_Trade.POS_SB_Import.Visible = True
End If


End Sub

Restarted and everything seems back to normal even when I do the same search and preview again.
 
Last edited:
Got a relatively minor bug. I run Windows 8.1, with my Philips 40" TV as my primary monitor, and a 21" HP monitor as a secondary monitor (gotta be able to read BOFH between trade runs :D). I have discovered a minor bug in TCE. Win 8 automagically enables High DPI Scaling when connected to large screens, to enable comfortable viewing of GUI elements at "10 foot display" distances. With High DPI enabled in Windows, TCE becomes unusable:


tce-high dpi 2.png

I didnt trim the pic for upload, the interface is being cut off because it is being DPI scaled. Not sure if there even is a fix for this, I am not a VBA programmer. The main reason I mention this is because I have a feeling many of us are eyeballing those new-fangled 4K displays, and I've read Windows uses DPI scaling on them as well.

This may have been reported before, but your thread has become rather unwieldy. Maybe a dedicated bug thread? This is an awesome enough proggie that I will be disabling DPI scaling to use it. Just my 2 cents. Thanks!!
 
Last edited:
Got a relatively minor bug. I run Windows 8.1, with my Philips 40" TV as my primary monitor, and a 21" HP monitor as a secondary monitor (gotta be able to read BOFH between trade runs :D). I have discovered a minor bug in TCE. Win 8 automagically enables High DPI Scaling when connected to large screens, to enable comfortable viewing of GUI elements at "10 foot display" distances. With High DPI enabled in Windows, TCE becomes unusable:



I didnt trim the pic for upload, the interface is being cut off because it is being DPI scaled. Not sure if there even is a fix for this, I am not a VBA programmer. The main reason I mention this is because I have a feeling many of us are eyeballing those new-fangled 4K displays, and I've read Windows uses DPI scaling on them as well.

This may have been reported before, but your thread has become rather unwieldy. Maybe a dedicated bug thread? This is an awesome enough proggie that I will be disabling DPI scaling to use it. Just my 2 cents. Thanks!!


have you tried fiddling with the zoom factor under options -> panels?
 
WOW Fantastic

Fantastic piece of coding managed to get it working without to many problems.
1 request.
On the main top panel somewhere underneath the station names could you put the commodity you are buying?
at the moment on trade runs you have to goto trade panel to see what to buy on return run. and when on auto route it would show you what to buy as well.
just a small text line that's says "Gold @ 9895" to so you can check price is correct.


Many thanks for a great bit of software
Cmdr Bupu
 
Last edited:
Fantastic piece of coding managed to get it working without to many problems.
1 request.
On the main top panel somewhere underneath the station names could you put the commodity you are buying?
at the moment on trade runs you have to goto trade panel to see what to buy on return run. and when on auto route it would show you what to buy as well.
just a small text line that's says "Gold @ 9895" to so you can check price is correct.

I was coming in to suggest just about the same thing ! :)


just a query where is the original database for prices from / how old is it. is it crowd sourced does it update at all without my ocr scanning the prices page.

Many thanks for a great bit of software
Cmdr Bupu


I do not know how old it is but I can tell you that it does not update without you doing it,
But since prices go up and down quite a bit, 1 month old data has nearly as much chance at being correct as 3 days old data lol

No crowd source at all unless you set up a FTP with some of your friends.
See the Menu Options.
 
you just beat me to it. already edited msg as I had found that out after reading the docs about updating..

cheers anyway.
cmdr Bupu
 
This is a great piece of work, well done to you. I had written off trading as a mindless 2-way grind before I found this, but now I can roam around my local area following the trade panel I'm actually finding it tolerable, and so I bought a T7.

If you'd like a hold full of palladium on me, just name the system.

I do have a couple of bug reports/questions though. Apologies if this has already been answered, this thread is getting pretty long and I can't seem to search a specific thread, possibly because I'm new to the forum.

Question: Is it possible to set a maximum distance-from-star value on the trade panel, in the same way as in the trade scout? I'd like to be able to play around with this value, to determine if the difference in travel time between first/second best stations is worth the difference in profit.

Bug-wise, I am also experiencing delimiter weirdness on the commodities panel. Comma is interpreted as a thousand separator, and I can't seem to key in periods at all, although I *can* paste them in from other rows in the commodities panel.

Also, whenever I do an OCR scan of the commodities market where the row for Painite is visible, it puts the sell price for Painite in the Bauxite row of the TCE commodities panel. If this is just an OCR thing, then fair enough. However I've experienced this with literally every station I've ever entered, and never experienced any other OCR errors at all, even though my resolution is borderline according to the EliteOCR documentation (1680x1050). Is there any special handling around painite in the code (due to it only ever being bought by stations and never sold) that might be going wrong?

If this is just an OCR fail, would it be possible to add a sanity check when saving the commodity prices that asks for confirmation if you're trying to save something that is obviously way out of line with the galactic average?
 
This is a great piece of work, well done to you. I had written off trading as a mindless 2-way grind before I found this, but now I can roam around my local area following the trade panel I'm actually finding it tolerable, and so I bought a T7.

If you'd like a hold full of palladium on me, just name the system.

I do have a couple of bug reports/questions though. Apologies if this has already been answered, this thread is getting pretty long and I can't seem to search a specific thread, possibly because I'm new to the forum.

Question: Is it possible to set a maximum distance-from-star value on the trade panel, in the same way as in the trade scout? I'd like to be able to play around with this value, to determine if the difference in travel time between first/second best stations is worth the difference in profit.

Bug-wise, I am also experiencing delimiter weirdness on the commodities panel. Comma is interpreted as a thousand separator, and I can't seem to key in periods at all, although I *can* paste them in from other rows in the commodities panel.

Also, whenever I do an OCR scan of the commodities market where the row for Painite is visible, it puts the sell price for Painite in the Bauxite row of the TCE commodities panel. If this is just an OCR thing, then fair enough. However I've experienced this with literally every station I've ever entered, and never experienced any other OCR errors at all, even though my resolution is borderline according to the EliteOCR documentation (1680x1050). Is there any special handling around painite in the code (due to it only ever being bought by stations and never sold) that might be going wrong?

If this is just an OCR fail, would it be possible to add a sanity check when saving the commodity prices that asks for confirmation if you're trying to save something that is obviously way out of line with the galactic average?

1: yes, between actual position and dest., click on trade, at the bottom right is a field trade range. change, hit enter, voila. clicking on dest. will give you the relevant stations now. been stumbling over this myself a long time... :D

edit: oops, misread you. distance from star surely is something else, that's not in there as far as i know.
eventure, please?

2: pls download the latest eliteocr version, it has to be added / included there or it won't recognise it. if you open eliteocr.exe by hand, it should give you an update note / link.
 
Last edited:
Question: Is it possible to set a maximum distance-from-star value on the trade panel, in the same way as in the trade scout? I'd like to be able to play around with this value, to determine if the difference in travel time between first/second best stations is worth the difference in profit.

No, its not possible at the moment. Perhaps i could add some filter options (like padsize or Star - Station distance) to the destination panel.

Bug-wise, I am also experiencing delimiter weirdness on the commodities panel. Comma is interpreted as a thousand separator, and I can't seem to key in periods at all, although I *can* paste them in from other rows in the commodities panel.

Thanks for the feedback. Will change that behavior in further beta versions (not the next). Releasing the V1.38 beta 1 version in the next 2 hours.

Also, whenever I do an OCR scan of the commodities market where the row for Painite is visible, it puts the sell price for Painite in the Bauxite row of the TCE commodities panel. If this is just an OCR thing, then fair enough. However I've experienced this with literally every station I've ever entered, and never experienced any other OCR errors at all, even though my resolution is borderline according to the EliteOCR documentation (1680x1050). Is there any special handling around painite in the code (due to it only ever being bought by stations and never sold) that might be going wrong?

Please update EliteOCR.

If this is just an OCR fail, would it be possible to add a sanity check when saving the commodity prices that asks for confirmation if you're trying to save something that is obviously way out of line with the galactic average?

It will come with an overhaul of the Commodity panel. Its on my to-do list.
 
Full-Version V1.38 beta 1 released:

Changelog:
- New startup routine to support an empty (no registered stations and prices) database, which is the default database from now on.
- Better recognition of your position in space.
- Hotkey issue: added a clear keyboard buffer, when hotkey was pressed.
- Database panel fixes, to prevent type-missmatch errors, when entering values.
- Delayed Star System Summary panel pop up, when jumping (10-15 secs.).
- Core redesign to fit the needs for further expansions of TCE and in preparation of the Elite-API.
- New Trade Station Name searchbox at the Position and Destination panel, adjusted sizes to reduce overlapping text.
- New Trade Station Service searchbox at the Trade panel, Find Commodity UI adjusted, use the arrow buttons to select search mode and some small fixes to Trade Range and Jump Limit.
- Commodity panel now clears all prices before scanning, when reaching a trade station to prevent issues with previous commodities, that are currently not available and added the activation of the Main panel before screenshot is taken.
- Bugfix to Trade Scout panel Pre-View function.
- Cartography panel: Click on the name of the star system, you are in to show up the Star System Summary panel and a small fix to the Star System Note panel to prevent save issues, when textbox is empty.
 
Last edited:
Full-Version V1.38 beta 1 released:

Changelog:
- New startup routine to support an empty (no registered stations and prices) database, which is the default database from now on.
- Better recognition of your position in space.
- Hotkey issue: added a clear keyboard buffer, when hotkey was pressed.
- Database panel fixes, to prevent type-missmatch errors, when entering values.
- Delayed Star System Summary panel pop up, when jumping (10-15 secs.).
- Core redesign to fit the needs for further expansions of TCE and in preparation of the Elite-API.
- New Trade Station Name searchbox at the Position and Destination panel, adjusted sizes to reduce overlapping text.
- New Trade Station Service searchbox at the Trade panel, Find Commodity UI adjusted, use the arrow buttons to select search mode, some small fixes to Trade Range and Jump Limit.
- Commodity panel now clears all prices before scanning, when reaching a trade station to prevent issues with previous commodities, that are currently not available and activation of the Main panel before screenshot is taken.
- Bugfix to Trade Scout panel Pre-View function.
- Cartography panel: Click on the name of the star system, you are in to show up the Star System Summary panel and a small fix to the Star System Note panel to prevent save issues, when textbox is empty.

Just for clarification what is the correct way to update the zip version when there's a new version. I've always just copied over the TCE.xlsm and over written it. If it's easier to upgrade via installer I'll switch to that.
 
Last edited:
Just for clarification what is the correct way to update the zip version when there's a new version. I've always just copied over the TCE.xlsm and over written it. If it's easier to upgrade via installer I'll switch to that.

If you have installed a previous version of TCE, you can install the update, when the requirements are met (there is an update note behind the download link). The full-version is a clean install, that removes some old files, that TCE doesn't need anymore. You can then import or copy your data from the old version to the new one. The way is yours.

First bug found: If you got LOCKED at the Trade Scout panel button, select a destination to make it accessable.
 
Last edited:
i directly get this error on start, updated from 1.37g:

View attachment 23956

edit: hu?
started again, loading with no errors.
i assume it had to do with beeing in the game menu, hadn't clicked 'start' jet. loaded my save, then retried and worked.
 
Last edited:
i directly get this error on start, updated from 1.37g:
edit: hu?
started again, loading with no errors.
i assume it had to do with beeing in the game menu, hadn't clicked 'start' jet. loaded my save, then retried and worked.

Thanks for the feedback, have to add a query, when no position found. Will be added in next beta version.
 
Got a subscript out of range when I jumped into a system (from blank start)

Panel_Menu_top.DES_Distance.Caption = DES_SysData(DES_StationID, 18) & " LY"
 
- Core redesign to fit the needs for further expansions of TCE and in preparation of the Elite-API.

Do you know something we don't, Eventure? I cannot find squat on further info on the Elite-API since Micheal closed the discussion thread back in February. Any inside scoop?
 
Got a subscript out of range when I jumped into a system (from blank start)

Panel_Menu_top.DES_Distance.Caption = DES_SysData(DES_StationID, 18) & " LY"

Found the problem, thats for feedback. It happens, when changing the star system and no destination was set before.

Do you know something we don't, Eventure? I cannot find squat on further info on the Elite-API since Micheal closed the discussion thread back in February. Any inside scoop?

Unfortunately not, but made TCE data managment more open for external input.
 
Last edited:
Status
Thread Closed: Not open for further replies.
Back
Top Bottom