Abandoned [RELEASE] Trade Computer Extension

Status
Thread Closed: Not open for further replies.

Osbo89

Osbo89
Eventure said:
Roger, displayed values are rounded now.



Uhhh.... that's a big one, requires a change of the Personal.mdb file, which will be made by TDM comming with the next full version.
For now, you have to spend your money to keep it below the limit, or note it elsewhere meanwhile. The upcomming limit will be 2^28 Credits.

Found also in the process of fixing some further bugs at the Credit panel. So thanks for making so much money :)
Click to expand...

Ok this is a fab program happy to wait.
 

Abil Midena

Abil Midena
Might have found a bug with the trade panel.

If you open the trade panel, where you have your current station on the left, and selected station on the right, TCE shows the "trade advisor outgoing" on the bottom left. This shows which commodity will give you the most profit if you fly to the current "selected station".
Also, on the bottom right, it shows "trade advisor returning", which lists the commodity you would get the most profit from if you went there and returned to where you are currently at.

Cool.

But, if you use the "find best sell price for" and choose the top listed commodity shown on the bottom left "outgoing" panel, it will list the places where you can get the best price for that. Also ok.

If you click on that station shown in "find best sell price for" / "trade station", TCE changes the "selected station" to that station (correctly), its imports/exports are changed (correctly) BUT the "trade advisor returning" does NOT update.

TL;DR: the "trade advisor (returning)" list does not update when changing stations via clicking a station in the "find best sell price for"/"trade station".

I hope that makes sense.
 

eventure

eventure
Abil Midena said:
Might have found a bug with the trade panel.

If you open the trade panel, where you have your current station on the left, and selected station on the right, TCE shows the "trade advisor outgoing" on the bottom left. This shows which commodity will give you the most profit if you fly to the current "selected station".
Also, on the bottom right, it shows "trade advisor returning", which lists the commodity you would get the most profit from if you went there and returned to where you are currently at.

Cool.

But, if you use the "find best sell price for" and choose the top listed commodity shown on the bottom left "outgoing" panel, it will list the places where you can get the best price for that. Also ok.

If you click on that station shown in "find best sell price for" / "trade station", TCE changes the "selected station" to that station (correctly), its imports/exports are changed (correctly) BUT the "trade advisor returning" does NOT update.

TL;DR: the "trade advisor (returning)" list does not update when changing stations via clicking a station in the "find best sell price for"/"trade station".

I hope that makes sense.
Click to expand...

It does. Found the missing call for the subroutine and it will be fixed with the next release.
 

RobH

RobH
Hi Eventure

TCE no longer seems immediately compatible with the update to Elite today. They changed the name of the folder.

I changed the NetLogPath and AppConfigPath manually to ....\FORC-FDEV-D-1010 which seems to be the new path in my EDLaunch folder.

After restarting Elite, TCE worked as per normal so far.

Rob
 

Abil Midena

Abil Midena
Eventure said:
It does. Found the missing call for the subroutine and it will be fixed with the next release.
Click to expand...

Awesome. I am using TCE even more since I have been floating around Fed space for the first time in a long time.

I am not looking forward to Horizons breaking OCR. I'm confident you'll adjust TCE for Horizons, but I think Elite OCR is going to be dead.
 

m00slim25

M
Today I enter data in Commodity form and instead of entering 0 do remove number and press a Enter button. Program has crashed into Debug window.
I analyzed the code and made some changes in procedure TB_Sell_Keydown.

If Ar_StationGoods(PR_SelectID, 5) = Ar_DBPrices(a, 1) Then
If Me.TB_Sell.Value = "" Then
Ar_DBPrices(a, 5) = 0
Call Setup_Commodities(Prices_StationID)
Exit For
Else
Ar_DBPrices(a, 5) = CLng(Me.TB_Sell.Value)
Call Setup_Commodities(Prices_StationID)
Exit For
End If
End If

This code do check form field value and replace it by 0 if it is empty.
After the changes TCE continued to normally work.

And I did same changes for TB_Buy_Keydown and TB_Stock_Keydown.
 
Last edited:

eventure

eventure
Abil Midena said:
Awesome. I am using TCE even more since I have been floating around Fed space for the first time in a long time.

I am not looking forward to Horizons breaking OCR. I'm confident you'll adjust TCE for Horizons, but I think Elite OCR is going to be dead.
Click to expand...

Wrote seeebek a PM, perhaps he will recognize it. Otherwise till the release of the .net version, we didn't get the supply values, so we have to enter them.
The new version will have an alternative to EliteOCR, but it will be nonetheless still important.

m00slim25 said:
Today I enter data in Commodity form and instead of entering 0 do remove number and press a Enter button. Program has crashed into Debug window.
I analyzed the code and made some changes in procedure TB_Sell_Keydown.

If Ar_StationGoods(PR_SelectID, 5) = Ar_DBPrices(a, 1) Then
If Me.TB_Sell.Value = "" Then
Ar_DBPrices(a, 5) = 0
Call Setup_Commodities(Prices_StationID)
Exit For
Else
Ar_DBPrices(a, 5) = CLng(Me.TB_Sell.Value)
Call Setup_Commodities(Prices_StationID)
Exit For
End If
End If



This code do check form field value and replace it by 0 if it is empty.
After the changes YCE continued to normally work.
Click to expand...

Oh yes, thanks for reporting. Changed all routines (sell, buy and stock) as noted above.

Will release the next full version of TCE tomorrow. Waiting of the new stuff translations.
 
Last edited:

eventure

eventure
Full Version (1.56 BETA 1) released:



Changelog(incl. minor updates):
- Fixed an error with the logbook, if stations were removed from the database by TDM.
- Updating Cartography panel correctly, when adding new stations.
- Fixed an issue at the Star System Summary panel control not displaying correctly when using the Compact UI.
- Fixed an issue at the Star System Summary panel with the stations scrollbar not working correctly.
- Fixed an issue with displaying different date formats. It now depends on the Windows date setting.
- Fixed an issue on missing Summary and Credit panel when unhiding the TCE interface.
- Fixed an issue on Compact View at the Commodity panel.
- Fixed an error on entering prices and stocks at the Commodity panel.
- Fixed an issue on displayed statistics at the Logbook panel.
- Fixed an overflow error at the Credit panel.
- Fixed an issue not updating the Trade Advisor display for returning commodities at the Trade Overview panel.
- Added new ship types (Horizons update).
- Added new station type (Horizons update).
- Added 18 new commodities (Horizons update).
- Added support for 64-bit Elite Dangerous version.
- Added Horizons compatibility in reference of the changed NetLog file information and name.
- Updated Language database (not all new stuff is translated, see notes below).

Note:
Please use the Transfer Database Manager (TDM) for TCE V1.55.2 and older versions to make your database compatible with the actual version of TCE.

This is a beta version, because not all new stuff is translated into all languages. If you want to help, please update the language.mdb file and send it to eventure(at)ki.tng.de.
It will be included into the next non-beta version of TCE.

Also, EliteOCR having problems on reading the new commodity menu of ED: Horizons. It can't read the supply value of displayed commodities anymore because of the new bars behind it. Don't know, if/when EliteOCR will be updated to be complatible with the Horizons update, but you can add the value manually at least.
 

m00slim25

M
When I try enter Distance to Reference Star 1 in Star System Database window program crashed to Debugger:

Procedure ChkSave()

CDbl(Me.TB_CoordX.Value) = <Type mismatch>

But Me.TB_CoordX.Value = "24.625"

I think error with "." because

CDbl(Ar_DBStars(Ar_DBLogbook(AzLogbook - 1, 4), 3) = "24,625"

PS. I live in Russia, use Windows with EN-US interface, but with Russian locale. I think trouble with it. :-(
 
Last edited:

Jameson_Bolmara

Jameson_Bolmara
Greetings,

Running the new Beta - Thanks BTW - I did manage the DB as per your instructions. When selecting a destination from the trade window I get a runtime error. the 4th screen shot show what happens when I exit Excel and the Debugger. The shots are numbered in order of actions.

Hope this helps

JB

Screenshot_1.jpgScreenshot_2.jpgScreenshot_3.jpgScreenshot_4.jpg
 

Jontron

J
Hello again, I tried downloading the new BETA version, however I get the same problem as I did before. After i try running the setup file, TCE_setup.exe opens up three processes that I can not kill or terminate through task manager and cmd line. Nothing else happens. Also I needed to try this new version because the older one will not load, the furthest it gets is bringing up excel with the message "IF TCE DOESNT START MACROS ARE DISABLED".
 

eventure

eventure
m00slim25 said:
When I try enter Distance to Reference Star 1 in Star System Database window program crashed to Debugger:

Procedure ChkSave()

CDbl(Me.TB_CoordX.Value) = <Type mismatch>

But Me.TB_CoordX.Value = "24.625"

I think error with "." because

CDbl(Ar_DBStars(Ar_DBLogbook(AzLogbook - 1, 4), 3) = "24,625"

PS. I live in Russia, use Windows with EN-US interface, but with Russian locale. I think trouble with it. :-(
Click to expand...

That could be a problem. You can change the delimiter setting at your Excel Options.

SpikeWLD said:
Greetings,

Running the new Beta - Thanks BTW - I did manage the DB as per your instructions. When selecting a destination from the trade window I get a runtime error. the 4th screen shot show what happens when I exit Excel and the Debugger. The shots are numbered in order of actions.

Hope this helps

JB

View attachment 85388View attachment 85389View attachment 85390View attachment 85391
Click to expand...

Found the problem. Releasing an update soon.

Jontron said:
Hello again, I tried downloading the new BETA version, however I get the same problem as I did before. After i try running the setup file, TCE_setup.exe opens up three processes that I can not kill or terminate through task manager and cmd line. Nothing else happens. Also I needed to try this new version because the older one will not load, the furthest it gets is bringing up excel with the message "IF TCE DOESNT START MACROS ARE DISABLED".
Click to expand...

Please use the source files instead and copy all three batch files from your old version into the new version. Please use the same folder name of TCE, or you have to modify the batch files.
Your system doesn't like WinRar self-extracting .EXE, right?
Will look for another installer for the next version.
If anyone knows a good (free) installer, please post it.
Thanks
 

eventure

eventure
Update (1.56 BETA 2) released:



Changelog:
- Fixed an error at the Destination panel, when selecting a station.

Note:
This update didn't need any TDM usage for your database. Copy the content into your TCE folder to update your version.
 
Last edited:

m00slim25

M
Eventure said:
That could be a problem. You can change the delimiter setting at your Excel Options.
Click to expand...
Its not help. Only change delimiter in Control Panel / Regional Settings. But this setting change decimal delimiter in all my old Excel tables. Why this setting has affect on your .xlsm project? E.g. when I change default system settings delimiter on "." and back again on "," it has effect in my Excel files but not in your project.
 
Last edited:

eventure

eventure
m00slim25 said:
Its not help. Only change delimiter in Control Panel / Regional Settings. But this setting change decimal delimiter in all my old Excel tables. Why this setting has affect on your .xlsm project? E.g. when I change default system settings delimiter on "." and back again on "," it has effect in my Excel files but not in your project.
Click to expand...

The Me.TB_CoordX.Value gets his value directly from a worksheet in the back. The cell is defined as a number. Here comes the windows setting into game, because you have set it to US ("." delimiter). Here in germany we use "," as a decimal delimiter.
The problem could come from your US/RU combi setting. Don't know, how to fix it here atm, that it will work with such settings.

I am hoping the .net version will have less localization issues.
 

Osbo89

Osbo89
Hi Eventure .

I'm getting a new problem when entering (1 409 000) for a run in the ships log a box comes up "runtime error 6 overflow" comes up
and just tried it with a lower number and the same thing happens.

thanks dee.
 
Status
Thread Closed: Not open for further replies.
Back
Top Bottom