Yep, that fixed it. Thanks Tromador.
In-Development TradeDangerous: power-user trade optimizer
- Thread starter kfsone
- Start date
Yep, that fixed it. Thanks Tromador.
Sorry about that, copies of my tdh.ini and tdhelper.db files were accidentally included in the release. I have updated the release without these files so that should sort this out.
That's what I meant. Random as to station, not as to message.
I wonder if we need to start trying to gather some data for this then and see if there is a pattern which isn't immediately obvious. The only (immediately obvious) common feature of my examples is that they were planetary.
It wouldn't be a bad idea. I can't see anything in the code that would account for it. I know there isn't any kind of error happening- it would show that.
How hard would it be to write an audit app?
I am thinking
Run listener and log messages to a file, say for an hour (possibly longer if need be).
Run an app which reads the log, checks the database timestamps on the recent systems and gives a list of all those where the timestamp hasn't been updated.
That is likely the best way to gather a meaningful amount of data quickly.
I don't think it should be too difficult. I can sort of see the pseudocode in my head, but it's been a while since I programmed much of anything.
I am thinking
Run listener and log messages to a file, say for an hour (possibly longer if need be).
Run an app which reads the log, checks the database timestamps on the recent systems and gives a list of all those where the timestamp hasn't been updated.
That is likely the best way to gather a meaningful amount of data quickly.
I don't think it should be too difficult. I can sort of see the pseudocode in my head, but it's been a while since I programmed much of anything.
No, it wouldn't be that difficult. I was thinking about doing something similar, i.e., having the listener print out what the information is supposed to be (the values from the message) versus the values it is (using a sql SELECT) immediately after doing the UPDATE, if they differ.
That said, right now my life is pretty much work,sleep,work,sleep, so I won't really have the time to do either until at least Friday. Hooray for days off.
That said, right now my life is pretty much work,sleep,work,sleep, so I won't really have the time to do either until at least Friday. Hooray for days off.
@Tromador - Sorry for the delay in getting back to you with the python installation instructions for the Mac, I got side tracked by TD Helper. The instructions are very simple as follows:
*****
Mac OS and Python
As of 10.9, OS X ships with Python 2.7.6. DO NOT "upgrade" your system to the latest version (3.7 at the time of writing) instead download the latest python installer for MacOs from https://www.python.org/downloads/. Once it has downloaded run the installer by locating the downloded file in the Filer and double-clicking the .pkg file or right-click on the file and choose 'Open'
Click on the 'Continue' button and the 'Agree' button where necessary until the last screen is reached where you press the 'Install' button and python will be installed. You will be asked to enter your admin password once the installation has started.
Checking it works
Open a terminal window and cd to the directory that contains the "trade.py" file from the source. Once you've found it, verify that it works by typing:
It should respond with basic usage instructions.
If you have installed a different verison simply change the 3.7 to the version that you just installed.
Proceed to the "Getting Started" section below
*****
I do have some screen shots if you need them. Send me a PM with an email and I'll bung them over.
*****
Mac OS and Python
As of 10.9, OS X ships with Python 2.7.6. DO NOT "upgrade" your system to the latest version (3.7 at the time of writing) instead download the latest python installer for MacOs from https://www.python.org/downloads/. Once it has downloaded run the installer by locating the downloded file in the Filer and double-clicking the .pkg file or right-click on the file and choose 'Open'
Click on the 'Continue' button and the 'Agree' button where necessary until the last screen is reached where you press the 'Install' button and python will be installed. You will be asked to enter your admin password once the installation has started.
Checking it works
Open a terminal window and cd to the directory that contains the "trade.py" file from the source. Once you've found it, verify that it works by typing:
Code:
$ python3.7 trade.py helpIt should respond with basic usage instructions.
If you have installed a different verison simply change the 3.7 to the version that you just installed.
Proceed to the "Getting Started" section below
*****
I do have some screen shots if you need them. Send me a PM with an email and I'll bung them over.
I don't think it's urgent, so I'll leave it and let you do it. If I did it, it would be in PERL (I need my curly braces dammit!) and take 10 times as long whilst I retrain myself in the how and why of simple scripting.
No problem making me wait. It's all stuff that needs doing before release, but we aren't exactly in a screaming rush, with different ling bugs/new features still to work on.
PM (about to be) sent. Thanks for helping out
Is it worth updating the Trade Dangerous page on ED Codex and adding a new page for the EDDBlink stuff?
I've added a page for TD Helper.
I've added a page for TD Helper.
Last edited:
That's the plan, but we're holding off on that until the kinks get worked out.
That said, the only real issues right now are with the listener, so I guess it'd be alright to do that now.
Maybe let me finish sorting out the documentation first. I've made some headway with it, but finding the time when I'm
a: Not at a hospital appointment for any one of my unique collection of chronic ailments.
b: Feeling well enough to do some work (on account of the aforementioned collection).
is hard at the moment. It doesn't help that the docs are (or were) an unholy mess with lots of what (imho) should have been separated out sections all being shoved into excessively long documents covering multiple topics.
Gimme a week or so and I'll have it done.
Although the only problem is with the listener, as we are labelling EDDBlink that out as the officially supported data source and that in turn relies on the listener (either via my server, or a local instance), I wonder if the current big problem with the listener picking stations to ignore shouldn't be fixed before we go to an official re-release of the tool.
Possibly. Revisit when documentation is finished, my vote.
Well, I have the documentation pretty much how I think it should be.
If you guys have the time/inclination please can you look it over and point out the glaring errors.
I do know it needs polishing, so please try to be nice at this stage, I will run it all through a spell checker and stuff before I declare it finalised - at this point I am more interested in big issues, not nitpicky ones, please.
Anything which is obviously blatantly wrong, or belongs in another document, or could be worded much better (with the better words, please) would be appreciated.
Note that I've taken the original (endlessly long) README.md and moved most of that into the wiki, so don't be surprised when you see that is now concise, with appropriate links to useful documents, rather than looking like the manual page for the Unix C Library.
So, see the README.md on https://github.com/eyeonus/Trade-Dangerous and all the rest is in the wiki https://github.com/eyeonus/Trade-Dangerous/wiki
If you guys have the time/inclination please can you look it over and point out the glaring errors.
I do know it needs polishing, so please try to be nice
at this stage, I will run it all through a spell checker and stuff before I declare it finalised - at this point I am more interested in big issues, not nitpicky ones, please.Anything which is obviously blatantly wrong, or belongs in another document, or could be worded much better (with the better words, please) would be appreciated.
Note that I've taken the original (endlessly long) README.md and moved most of that into the wiki, so don't be surprised when you see that is now concise, with appropriate links to useful documents, rather than looking like the manual page for the Unix C Library.
So, see the README.md on https://github.com/eyeonus/Trade-Dangerous and all the rest is in the wiki https://github.com/eyeonus/Trade-Dangerous/wiki
Why was the licensure changed to the restrictive copyleft GPL 3.0? If you're worried aout warranty, use BSD2 or MIT. If you want future development of this code to be released as FLOSS use the MPL 2.0. GPL is strongly copylefted and means that no one else can develop TD without releasing their ENTIRE work as GPL. I'm strongly tempted to fork the project before that change JUST for that reason,
Furthermore, legally, I am not sure you can change any of the licensure without permission of all the contributors of work in the current state. That is more than just eyeonus and tromador. I would stringly urge this to be undone and rethought. https://github.com/eyeonus/Trade-Dangerous/issues/16
Furthermore, legally, I am not sure you can change any of the licensure without permission of all the contributors of work in the current state. That is more than just eyeonus and tromador. I would stringly urge this to be undone and rethought. https://github.com/eyeonus/Trade-Dangerous/issues/16
Mark - Not that I can go far wrong with cut & paste, but please can you give the mac section of the setup guide a quick glance over and make sure I haven't screwed up anywhere. Thanks
There's a line break in there that should probably be removed after "(3.7 at the time of writing)." but apart from that it looks fine.
The only copyright that has been asserted is Oliver's original, which says you can do anything provided it is included. My research (I did look this up extensively before making the change) says you can add restrictions, but not remove them - if you think differently wrt GPL or where multiple contributors are concerned, please cite.
As it stood, there was zero licensing, such that the entire project could be downloaded, wrapped up and released entirely as a closed project with 3 lines of Oliver's copyright included in a plain text header.
I pretty much went with GPL (after discussing with Eyonus) because EDDBLink is already under LGPL.
So before you decide to strike down upon us with great vengeance and furious anger, I am not averse to a less restrictive licence, so long as it ensures that TD remains free and open source. Maybe I should have thrown it out for discussion first, but I do want our hard work protected by something more robust than
Code:
# You are free to use, redistribute, or even print and eat a copy of
# this software so long as you include this copyright notice.
# I guarantee there is at least one bug neither of us knew about.Do you want to talk about this, with a view to potentially making a change, or just be the last angry man? If it was a dumb thing to do, I'm happy to discuss, but not if you are going to throw your toys out of the pram or take the bull in a china shop approach.
Last edited: