Market Connector not Showing Station?

Random Player

Random Player
MarkAusten said:
I have a working EDMC and the station setting is EDDB.
Click to expand...
I changed my Preferred Website for "Station" from INARA to EDDB and now it works!

7-20-2020 11-28-51 AM.png
 

Random Player

Random Player
It actually works the best with EDSM. After I changed Station from INARA to EDDB, I could no longer click on the System, but could with Shipyard and Station. I changed Station and dSystem to EDSM and now, it all works, so far ;)

7-20-2020 11-28-51 AM.png
 

Random Player

Random Player
MarkAusten said:
Rats!
Click to expand...
OK, this is stupid... but, I changed Preferred Websites back to EDDB, and lost the ability to click on "System". However, for now, I closed and reopened and hit update and, with Station and System set to EDDB, I now have all three options showing and working, for now.
 

Athan

Athan
Can those of you who have this bug (or hey, if you don't) with 4.0.2.0 please test this Release Candidate. I found the bug, but then started digging into a few other cleanups and enhancements as well. You should switch back to Inara as your provider.

github.com

Release Release Candidate 4.0.3-rc2 · EDCD/EDMarketConnector

Release Candidate 4.0.3-rc2 This is exactly the same as -rc1 except I fixed a missing line of code that prevented the EDSM plugin from loading.
github.com github.com
github.com

Release Release Candidate 4.0.3-rc1 · EDCD/EDMarketConnector

Release Candidate 4.0.3-rc1 The main purpose of this Pre-Release is to test fixes to the System and Station provider code supplied by the internal plugins. But we've also now switched to full Sema...
github.com github.com
 
Last edited:

MarkAusten

MarkAusten
Athan said:
Can those of you who have this bug (or hey, if you don't) with 4.0.2.0 please test this Release Candidate. I found the bug, but then started digging into a few other cleanups and enhancements as well. You should switch back to Inara as your provider.

https://github.com/EDCD/EDMarketConnector/releases/tag/Release/4.0.3-rc1
Click to expand...
So far, so good.

Windows 10 defender complained, no problem told it to run the installer anyway.
I have Elite open, ran EDMC, no system or station despite being docked.
Changed station provider to Inara, still no system or station.
Pressed the update button and now have both system and station showing.
 

Athan

Athan
MarkAusten said:
Windows 10 defender complained, no problem told it to run the installer anyway.
Click to expand...
Yeah, brand new file, and despite me having installed it myself that, of course, won't be enough to tag it as "not bad" (else virus writers could just do that!). There's apparently no good free solution for code signing certificates, and this being an Open Source project there's no funds to pay for a certificate (and keep paying every X years for a new one).

MarkAusten said:
I have Elite open, ran EDMC, no system or station despite being docked.
Changed station provider to Inara, still no system or station.
Pressed the update button and now have both system and station showing.
Click to expand...
That implies it's having issues picking up your journal files. Any errors in %TEMP%\EDMarketConnector.log ? You have to check it in the same session of running EDMarketConnector.exe, as it's truncated each time. I definitely wasn't having this issue myself, and I was repeatedly re-running EDMC whilst logged in, both docked and not, to test each code tweak.
 

MarkAusten

MarkAusten
Log contents:

Code: 
E:D Market Connector 4.0.3-rc1 2020-07-21T17:57:59
loading plugin coriolis from "C:\Program Files (x86)\EDMarketConnector\plugins\coriolis.py"
loading plugin eddb from "C:\Program Files (x86)\EDMarketConnector\plugins\eddb.py"
loading plugin eddn from "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py"
loading plugin edsm from "C:\Program Files (x86)\EDMarketConnector\plugins\edsm.py"
Traceback (most recent call last):
  File "plug.pyc", line 97, in __init__
  File "<frozen importlib._bootstrap_external>", line 407, in _check_name_wrapper
  File "<frozen importlib._bootstrap_external>", line 907, in load_module
  File "<frozen importlib._bootstrap_external>", line 732, in load_module
  File "<frozen importlib._bootstrap>", line 265, in _load_module_shim
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Program Files (x86)\EDMarketConnector\plugins\edsm.py", line 219
    this.station = entry.get('StationName') or this.station
       ^
IndentationError: expected an indented block
loading plugin edsy from "C:\Program Files (x86)\EDMarketConnector\plugins\edsy.py"
loading plugin inara from "C:\Program Files (x86)\EDMarketConnector\plugins\inara.py"
 

Athan

Athan
NB: if installing 4.0.3-rc2 (or any later) you must first explicitly Uninstall the application if coming from a previous 4.0.3-rcX version.

Basically msiexec (the program in Windows that actually does the installing) sees "4.0.3.0" for any of these release candidates, and thus might not do the right thing when upgrading in-place (because it doesn't really think it's an upgrade).

If only msiexec (and a few other bits) would actually support proper full Semantic Version strings then we wouldn't have this problem.
 

Athan

Athan
I just tested the eddb plugin fairly thoroughly myself. Here's a link to my comment on the github issue that outlines what I did. There are still other combinations even with just the eddb plugin because in theory the tracked state could depend on if you have EDSM and Inara API keys set, or not. I had both set for that testing, so there's another 3 combinations of it all right there. There's no option with EDMC to not have Frontier Authorization done, so the CAPI calls on docking will always happen. There's also the options for if you're sending data to EDSM or Inara that might have an impact on the tracked state.

I'd appreciate anyone with the time:

1) Downloading 4.0.3-rc2 as above.
2) UNINSTALLING any prior version. Your settings are safe in the registry, and you should have only been installing third-party plugins inside your user 'AppData' area, not in the actual EDMC install location, so it will all be safe.
3) Installing 4.0.3-rc2.
4) Running through the same testing I did in that github issue comment with their current preferred configuration.
5) Report any issues you find, preferably on that github issue. Remember to include %TEMP%\EDMarketConnector.log if you encounter any issues.
 
You must log in or register to reply here.
Back
Top Bottom