In-Development TradeDangerous: power-user trade optimizer

nepo

nepo
errormessages

what does this mean?

C:\Windows\system32>trade.py import -P edapi -O eddn
@SKIRARAGEA/J. G. Ballard Holdings
<tradedb.Station object at 0x00000000062746D0>
NOTE: SKIRARAGEA/J. G. Ballard Holdings (#43442) updated in local db: shp('N'=>'Y')
NOTE: C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\data\Station.csv updated.
Traceback (most recent call last):
File "C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\trade.py", line 104, in <module>
main(sys.argv)
File "C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Users\Gerhard\SkyDrive\Dokumente\REPOS\TradeDangerous_280516\plugins\edapi_plug.py", line 3836, in run
eddn_ships.append(eddn_ship_names[ship])
KeyError: 'Viper_MkIV'
Click to expand...

greetings
 

CMDR Ibizan

C
nepo said:
what does this mean?



greetings
Click to expand...

nepo,

I'm not an expert but it looks as though the problem is the Viper MkIV. That would suggest that your version doesn't know what that is. You could try getting the latest version of ship.csv from Maddavo's site (www.davek.com.au). In fact get all of the csv files from his download data section and put them in your trade/data folder.

That might fix it - it shouldn't do any harm anyway!

good luck
 

gazelle

gazelle
I've updated my horizon branch:

  • "--no-planet" switch now requires planetry to be "N" (issue #5)
  • Updated README
  • latest data update from maddavo
  • New items for 1.6/2.1 update
  • Update EDAPI plugin to version 3.6.2

@maddavo:
I think your Ship.csv is outdated and I've added one item to the Item.csv.
 
Last edited:

Karunamon

Karunamon
gazelle said:
I've updated my horizon branch:

  • "--no-planet" switch now requires planetry to be "N" (issue #5)
  • Updated README
  • latest data update from maddavo
  • New items for 1.6/2.1 update
  • Update EDAPI plugin to version 3.6.2

@maddavo:
I think your Ship.csv is outdated and I've added one item to the Item.csv.
Click to expand...

Hmm.. is this branch (and my not using it yet) the reason why I continue to get "unrecognized item name" on basic/common commodities like water?

Where can I download it?
 

maddavo

maddavo
gazelle said:
@maddavo:
I think your Ship.csv is outdated and I've added one item to the Item.csv.
Click to expand...

Are "Trinkets of Hidden Fortune" a standard commodity? I thought they were rare.

- - - - - Additional Content Posted / Auto Merge - - - - -

Karunamon said:
Hmm.. is this branch (and my not using it yet) the reason why I continue to get "unrecognized item name" on basic/common commodities like water?

Where can I download it?
Click to expand...

You need to update your item.csv file so that it contains newer items - then those items will be recognised. If you update TD from gazelle's horizon's branch then the item.csv will contain all those items.

https://bitbucket.org/bgol/tradedangerous/branch/horizon
 

Karunamon

Karunamon
maddavo said:
You need to update your item.csv file so that it contains newer items - then those items will be recognised. If you update TD from gazelle's horizon's branch then the item.csv will contain all those items.

https://bitbucket.org/bgol/tradedangerous/branch/horizon
Click to expand...

Thanks - I tried that, but I'm still getting the errors. (Unrecognized item name: "WATER" and a boatload of others)

I cloned the repo, cd'd in, and ran the usual 'trade.py update -P maddavo -O csvs,usefull'
 

gazelle

gazelle
Karunamon said:
I cloned the repo, cd'd in, and ran the usual 'trade.py update -P maddavo -O csvs,usefull'
Click to expand...

If you have cloned the repo you will be in the "master" branch. You need to checkout the "horizon" one.
Code: 
git checkout horizon

The "Water" item is definitly in the Item.csv from the horison branch.
 

gazelle

gazelle
@maddavo:

I read in the EDMC thread that 'Power Transfer Conduits' should be named 'Power Transfer Bus'. This would need an update for the edapi plugin, the Item.csv and your item correction for the maddavo plugin.

Can anyone confirm this? -> Ok, found it myself and it is true. Updated the horizon branch with the rename.

BTW: The prices-file doesn't need the category-line because itemnames are unique, if you wanna save some bandwith.
 
Last edited:

gazelle

gazelle
maddavo said:
I've updated the System.csv to change NARAKA and NARAKA (Alternate). These are now ARBUDA and NARAKA respectively.
Click to expand...

Ok, I've updated the horizon branch with your latest data.

BTW: You still haven't updated the Item.csv and Ship.csv files on your website.
The item rename from 'Power Transfer Conduits' to 'Power Transfer Bus' is important because EDMC does send it (since v2.12).
 

maddavo

maddavo
gazelle said:
Ok, I've updated the horizon branch with your latest data.

BTW: You still haven't updated the Item.csv and Ship.csv files on your website.
The item rename from 'Power Transfer Conduits' to 'Power Transfer Bus' is important because EDMC does send it (since v2.12).
Click to expand...

OK - I'll get on that today.
 

gazelle

gazelle
maddavo said:
I've updated the Item.csv with Power Transfer Bus and the Trinkets of Hidden Fortune, and also updated the Ship.csv .
Click to expand...

I think it's best to keep in sync with EDMC because many cmdrs are using it to report to EDDN. I'll keep the Conduits->Bus correction in the horizon-code, just to be save.

edit: Do you still need the EDSM update? The netLog does provide the coords for systems now.
 
Last edited:

maddavo

maddavo
gazelle said:
I think it's best to keep in sync with EDMC because many cmdrs are using it to report to EDDN. I'll keep the Conduits->Bus correction in the horizon-code, just to be save.

edit: Do you still need the EDSM update? The netLog does provide the coords for systems now.
Click to expand...

The import thing is to keep in sync with ED itself. EDMC and other tools that use the API to send the item names to EDDN all use the names that the API reports. Sometimes the API reports names differently from what is in-game. (I imagine this is because at some point the devs decided to change the name that appears in-game and didn't bother to change all the behind-the-scenes code - easier to just make a cosmetic change). That is where corrections tables are important to map to the in-game names. The tools that report to EDDN should do the mapping before sending to EDDN but some only do this to varying degrees - particularly when updates come about and the actual in-game names are not confirmed. I'm pretty sure we have all the items mapped properly to the in-game names now and as long as we are consistent with that as a goal then we can map anything that comes via EDDN to what the in-game names are.

So basically both EDDN publishers and EDDN listeners should have a translation map and try to keep to in-game names as much as possible. As long as that is the case then the corrections.py should effectively be empty - which is what kfsone and I worked to achieve with the corrections.csv .

Yes, still need the EDSM update. Hopefully EDDiscovery will be updated so that it gets the coords for unknown systems from the netLog and then automatically submit them to EDSM. Alternatively maybe we could have something that parsed the netLog and added to the System.csv . In any case I'd like to get the master System.csv updated from EDSM with all the systems that are within 500Ly from SOL. I think it should help with finding more trade routes solutions in TD.
 
Last edited:

maddavo

maddavo
To illustrate - I have just seen a good example of an API tool not doing translation properly before publishing to EDDN:

For the item "Microbial Furnaces", the API returns "Heliostatic Furnaces". Elite: Dangerous Assistant v0.95 seems to not know that in-game the item is "Microbial Furnaces" and sending "Heliostatic Furnaces" via EDDN. The MMS EDDN listener has the translation for Heliostatic Furnaces already and so translates to Microbial Furnaces so that's what we see in the prices files. But really the tool should publish only in-game data to EDDN so I'll send a msg to the author of ED Assistant.
 

maddavo

maddavo
More maintenance...

"Low Temperature Diamond" is now "Low Temperature Diamonds"
Item.csv has been updated

To update this one there are a few steps:
* download and replace the Item.csv in your data folder
* Do a bulk replace in your local .prices file for "Diamond" to "Diamonds"
* do a buildcache - "trade buildcache -fi"
* Then do a maddavo update with corrections - "trade import -P maddavo -O Corrections,Stations,exportcsv"
 
You must log in or register to reply here.
Back
Top Bottom