I'm fairly certain TD ignores demand values. If there's a price it can be sold, TD will consider selling it there, whatever the demand.
In-Development TradeDangerous: power-user trade optimizer
- Thread starter kfsone
- Start date
I'm fairly certain TD ignores demand values. If there's a price it can be sold, TD will consider selling it there, whatever the demand.
Its not the case. When I told TD to do a trade check between two stations it gave me a 600/t with coffee and tea.
However I am trading imp. slaves with over 3000/t over the same station. So TD is not considering this trade due to something.
.
If I use TD to check what I can sell to this station- imp. slaves is not in the list. So TD is missing it for some reason.
I can only see this to demand being blank (demand is not 0 - it is nothing in the demand box) or TD gets confused when you can buy and sell the same item.
What is 100% sure is that TD is not considering this trade opportunity for one reason or the other.
.
Just to be clear. I have made over 50 mill on this trade route over the last couple of days.
However I am trading imp. slaves with over 3000/t over the same station. So TD is not considering this trade due to something.
.
If I use TD to check what I can sell to this station- imp. slaves is not in the list. So TD is missing it for some reason.
I can only see this to demand being blank (demand is not 0 - it is nothing in the demand box) or TD gets confused when you can buy and sell the same item.
What is 100% sure is that TD is not considering this trade opportunity for one reason or the other.
.
Just to be clear. I have made over 50 mill on this trade route over the last couple of days.
Last edited:
Code:
v7.2.0 Jun 14 2015:
. (Orphu) Created an import plugin that uses Frontier's Mobile API,
- See README.md for more help,
- Use "trade.py import -P edapi" to get started,
- Able to optionally upload prices it pulls to EDDN:
trade.py imp -P edapi -O eddn
. (maddavo) Fixed/merged lots of new systems,
I jumped on the 7.2.0 as soon as I saw this.
I am liking the edapi plugin. I have my voice attack profile launch it with the "Pull List" Command so I can quickly update even if I am not trading.
One thing I did notice is now when I update I am getting something that I didn't get before, and I am not sure if its an error or not.
Is this an error or something else?
I am liking the edapi plugin. I have my voice attack profile launch it with the "Pull List" Command so I can quickly update even if I am not trading.
One thing I did notice is now when I update I am getting something that I didn't get before, and I am not sure if its an error or not.
Code:
Traceback (most recent call last):
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\trade.py", line 104, in <module>
main(sys.argv)
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Users\Kevin\Documents\Gaming Related\EliteDangerous\Tools\kfsone-tradedangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.nameIs this an error or something else?
Last edited:
looks like data issues at davo's end. ocr derp or possibly malicious data entered.
Still seeing the error 
Pulled current repo (as zip file if that makes difference) directly before running python trade.py import --plug=maddavo --opt=corrections --opt=csvs
...
NOTE: Added local station placeholder for THOSIAO/FOCER ORBITAL (#41432)
NOTE: Added local station placeholder for TSOHOCK/RERSCHEL TERMINAL (#41433)
NOTE: Added local station placeholder for VANAYEQUI/CBUSS HUB (#41434)
NOTE: Placeholder stations are added to the local DB only (not the .CSV).
Use 'trade.py export --table Station' if you /need/ to persist them.
NOTE: Import complete: 773204 new items over 14,252 stations in 8,147 systems
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
running python trade.py import --plug=maddavo --opt=csvs had same effect, tried to do corrections without the corrections switch passed anyway. Running python trade.py import --plug=maddavo got the prices fine as expected without trying to do the corrections and no error.
Pulled current repo (as zip file if that makes difference) directly before running python trade.py import --plug=maddavo --opt=corrections --opt=csvs...
NOTE: Added local station placeholder for THOSIAO/FOCER ORBITAL (#41432)
NOTE: Added local station placeholder for TSOHOCK/RERSCHEL TERMINAL (#41433)
NOTE: Added local station placeholder for VANAYEQUI/CBUSS HUB (#41434)
NOTE: Placeholder stations are added to the local DB only (not the .CSV).
Use 'trade.py export --table Station' if you /need/ to persist them.
NOTE: Import complete: 773204 new items over 14,252 stations in 8,147 systems
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
running python trade.py import --plug=maddavo --opt=csvs had same effect, tried to do corrections without the corrections switch passed anyway. Running python trade.py import --plug=maddavo got the prices fine as expected without trying to do the corrections and no error.
Last edited:
Still seeing the error
...
NOTE: Added local station placeholder for THOSIAO/FOCER ORBITAL (#41432)
NOTE: Added local station placeholder for TSOHOCK/RERSCHEL TERMINAL (#41433)
NOTE: Added local station placeholder for VANAYEQUI/CBUSS HUB (#41434)
NOTE: Placeholder stations are added to the local DB only (not the .CSV).
Use 'trade.py export --table Station' if you /need/ to persist them.
NOTE: Import complete: 773204 new items over 14,252 stations in 8,147 systems
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
running python trade.py import --plug=maddavo --opt=csvs had same effect, tried to do corrections without the corrections switch passed anyway. Running python trade.py import --plug=maddavo got the prices fine as expected without trying to do the corrections and no error.
Try this:
Code:
trade import -P maddavo -O stations
trade import -P maddavo -O corrections,exportcsvThen use this for usual imports:
Code:
trade import -P maddavo -O corrections,stations,exportcsv- - - Updated - - -
Some station/market stats as of now:
| 41406 Stations in 19011 Systems | |
|---|---|
| Distance | 9345 (<1000Ls), 4624 (1000Ls - 10000Ls), 1863 (>10000Ls), 25574 unknown |
| Pad | 6816 L pad, 9185 M pad, 25405 unknown |
| Market | 14320 (14320) markets with prices, 20437 markets without prices, 3619 no markets, 3030 unknown |
| Market / Pad | 5523 L-pad markets with prices, 4870 M-pad markets with prices, 3927 unknown pad markets with prices |
Last edited:
Sadly no, still
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
Cloned td via git in case it was an error via the zip version but still same response Is it just me seeing this?
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
Cloned td via git in case it was an error via the zip version but still same response
Is it just me seeing this?No Hitchhiker, I get the same.
I don't have the latest git version - I'll get it and have a look.
------UPDATE------
Mmm. I updated TD and ran import - worked OK. (I do keep some of my data files though)
Maybe try doing a buildcache before the import:
Continuing testing I made a new directory and used a vanilla TD from the git. Then ran the following 3 commands:
This WORKED OK.
The only thing I can think is maybe something might still be hanging around your data directory? I'm not sure where the corrections.csv file goes when it is D/L'd - maybe get rid of the old one if it is there.
------UPDATE------
Mmm. I updated TD and ran import - worked OK. (I do keep some of my data files though)
Maybe try doing a buildcache before the import:
Code:
trade buildcache -fiContinuing testing I made a new directory and used a vanilla TD from the git. Then ran the following 3 commands:
Code:
trade import -P maddavo -O corrections,stations,shipvendors,exportcsv,usefull,force
trade import -P maddavo -O corrections,stations,shipvendors,exportcsv,use2d,force
trade import -P maddavo -O corrections,stations,shipvendors,exportcsv,use3h,forceThis WORKED OK.
The only thing I can think is maybe something might still be hanging around your data directory? I'm not sure where the corrections.csv file goes when it is D/L'd - maybe get rid of the old one if it is there.
Last edited:
Yeah blanking the data dir fixed it, thanks for your time Davo All working fine again.
All working fine again.
Hi,
I have question / suggestion about the edscupdate.py
Is there any possibility to send new data like "oneliner"
Where those distances are from Sol, New Yembo, Vesuvit, HIP 79884 and Asellus Australis.
I get the distances on galaxy map, draw them on paper and then write them on spreadsheet. After a long exploration trip I just want to run some csv-file in a do-while loop here.
Erroreous entries can be write on error.log for manual updating, checking, etc
I have question / suggestion about the edscupdate.py
Is there any possibility to send new data like "oneliner"
Code:
python3 edscupdate.py --cmdr boozeman --oneliner "HR 406" "373.64, 427.01, 398.63, 537.18, 427.12"Where those distances are from Sol, New Yembo, Vesuvit, HIP 79884 and Asellus Australis.
I get the distances on galaxy map, draw them on paper and then write them on spreadsheet. After a long exploration trip I just want to run some csv-file in a do-while loop here.
Erroreous entries can be write on error.log for manual updating, checking, etc
Last edited:
Hi,
I have question / suggestion about the edscupdate.py
Is there any possibility to send new data like "oneliner"
Code:python3 edscupdate.py --cmdr boozeman --oneliner "HR 406" "373.64, 427.01, 398.63, 537.18, 427.12"
Where those distances are from Sol, New Yembo, Vesuvit, HIP 79884 and Asellus Australis.
I get the distances on galaxy map, draw them on paper and then write them on spreadsheet. After a long exploration trip I just want to run some csv-file in a do-while loop here.
Erroreous entries can be write on error.log for manual updating, checking, etc
Try using "submit-distances.py" instead
But no, it still doesn't support allowing you to input the distances like that. Both tools are reliant on prompting - you submit the names of places and it asks you to verify the distances.
Last edited:
Sadly no, still
NOTE: Importing Corrections
Traceback (most recent call last):
File "trade.py", line 104, in <module>
main(sys.argv)
File "trade.py", line 77, in main
results = cmdenv.run(tdb)
File "C:\Temp\TradeDangerous\commands\commandenv.py", line 80, in run
return self._cmd.run(results, self, tdb)
File "C:\Temp\TradeDangerous\commands\import_cmd.py", line 124, in run
if not plugin.run():
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 708, in run
self.import_corrections()
File "C:\Temp\TradeDangerous\plugins\maddavo_plug.py", line 232, in import_corrections
db.execute(stmt, binds)
sqlite3.IntegrityError: UNIQUE constraint failed: Station.system_id, Station.name
Cloned td via git in case it was an error via the zip version but still same response
I too am getting this error both before and after updating TD this morning
Update:I've fixed this by first running
Code:
trade.py import --plug maddavo --opt=csvonly,shipvendors,stations,systemsi.e. everything bar corrections. I immediately then ran
Code:
trade.py import --plug maddavo --opt csvs,csvonlyCorrections ran correctly this time, and since then the error has gone?
Something bad crept in for sure. As above I cleared my data dir manually at Davo's suggestion and did a full update. It's all working nicely and noticeably faster than before.
After you clone from git, your first step should be:
or
I think we've reached a point where I should make '-i' a default behavior and simply introduce a flag to disable it (although I can't remember the last time I wanted TD to *not* do -i).
Code:
trade.py buildcache -fi
Code:
trade.py buildcache -fiqI think we've reached a point where I should make '-i' a default behavior and simply introduce a flag to disable it (although I can't remember the last time I wanted TD to *not* do -i).
