Abandoned [RELEASE] Trade Computer Extension

Status
Thread Closed: Not open for further replies.
BTW seeebek, I'm really glad EliteOCR didn't choke on this typo I found in-game yesterday =)

View attachment 33325
This is what FD did with the commodities which are too long. They cut the last number. In the past it was there, just shifted down. Which was much worse for OCR. I dont correct it with a 0 at the end because its not important if you have a supply of 19,000,000 or just 1,900,000. It's still very high.
 
Just tried unblock in Windows 8.1, and on TCE start up got following:

Error in Startsequence
Error Line: 10

Error: (5) Invalid procedure call or argument

I think, i found the problem, changed the ini file reading, so it will be fixed in next update.

I was mistaken. Apparently when a relative path is used, Windows executes that from the location of the shortcut rather than the original .bat file sitting next to the .xlsm. So each user would have to manually copy/paste their TCE directory path into the .bat, which is not a hard thing to do from Windows Explorer anyway. OR the installer could just do it for them =) Maybe someone with more batch talent knows a way to reference the original batch file's directory in lieu of the shortcut's, but I couldn't find any such thing after a quick Google.

Thanks for all you input. The batch solution is working fine here. I managed to create an additional batch file (init.bat), that creates both TCE.bat and TCE_Setup.bat with the correct path names. I will add the call for the init.bat from the Prestart.bat, so the installer creates these files and add a shortcut for both files to the desktop. Managed also to kill the cmd.exe window out of TCE, when it starts. Good work and thanks again for the tip.

@Putted now all together into the prestart.bat and we have a new installer. Will be released with the next full-version.
 
Last edited:
I've been running TCE all evening with UAC full on,
without having UNBLOCKED either .xlsm or running the batch file that I have made !

It's been hours, I've scanned, used Trade Scout, locked route ... without any problem !!

Is it possible that after you run TCE for a while with UAC off,
UAC will let you run files with the same name without warning after you turn it back on ???
Essentially learning or white listing everything that is already in the computer before you turn it on ???
 
Last edited:
Set up TCE with 1.39f and the latest EliteOCR yesterday. Worked great once I finally got the panels resized and my FOV set to a place where EliteOCR would accept the screen captures. (I'm running 1680x1050, an unfortunate limit of my old monitor.) This morning, though, I ran into an error that is causing a loop in Excel that can only be solved by restarting the computer.

Error in EDLog_Read
Error Line: 10

Error: (52) Bad file name or number

Saying "OK" that that error, I then get:

Error in EDLog_Read
Error Line: 20

Error: (9) Subscript out of range

Saying "OK" to that brings me back to the first Error above.

What I recall was I had run a mission and come back to a station to do some trading. So, I hit the "Trade" button up in the menu, and that's when the error happened. The top menu stays in place. I can kill that process independently, but Excel can't be closed because of the pop-up error dialogues. Windows 7, Office 2013.

I figure I can reinstall TCE, or maybe just the TCE.xlsm? Is there something I can do to avoid in the future?

OO
 
Set up TCE with 1.39f and the latest EliteOCR yesterday. Worked great once I finally got the panels resized and my FOV set to a place where EliteOCR would accept the screen captures. (I'm running 1680x1050, an unfortunate limit of my old monitor.) This morning, though, I ran into an error that is causing a loop in Excel that can only be solved by restarting the computer.



Saying "OK" that that error, I then get:



Saying "OK" to that brings me back to the first Error above.

What I recall was I had run a mission and come back to a station to do some trading. So, I hit the "Trade" button up in the menu, and that's when the error happened. The top menu stays in place. I can kill that process independently, but Excel can't be closed because of the pop-up error dialogues. Windows 7, Office 2013.

I figure I can reinstall TCE, or maybe just the TCE.xlsm? Is there something I can do to avoid in the future?

OO

Please, could you tell the your last NetLog filenames, they are in the Logs folder of ED. There is something TCE didn't like.
There is no need in a reinstall. Just close TCE (the hard way) and ED. Start ED first and go into your save, so ED can create a new logfile, then start TCE as usual.

If you run into the same error again, then do the following:
- open the netlog folder of your ED installation
- identifiy the last netlog files from this day
- delete them all
- restart ED and then TCE

It has to do with the filenames. Each start, ED creates a new logfile. If there was a log with the same date name, it adds one to the end of filename. If you running ED ten times at the same day, TCE breaks here. Will be fixed in next update.
 
Last edited:
phew. this is definately hard work.
someone should pay me for this...:

View attachment 33416

i think i'll lean back for some time, happily awaiting the trade route planner.
man, i'm gonna make them monies then...
:D

double thanks again to eventure and seeebek,
making this hard work... well. fun.
:)
 
@Eventure

No pressure, just a question !

You did such a great job optimizing the scan process,
I appreciate it a lot, even thought I didn't know I needed it before you did lol

So of course now I'm wondering if you could not also optimize the saving of the commodities.
Everything else is so quick that saving a full market feels quite slow now !
 
@Eventure

No pressure, just a question !

You did such a great job optimizing the scan process,
I appreciate it a lot, even thought I didn't know I needed it before you did lol

So of course now I'm wondering if you could not also optimize the saving of the commodities.
Everything else is so quick that saving a full market feels quite slow now !

Yes, its the last save routine, that did not get an overhaul. But that will come.
 
I was mistaken. Apparently when a relative path is used, Windows executes that from the location of the shortcut rather than the original .bat file sitting next to the .xlsm. So each user would have to manually copy/paste their TCE directory path into the .bat, which is not a hard thing to do from Windows Explorer anyway. OR the installer could just do it for them =) Maybe someone with more batch talent knows a way to reference the original batch file's directory in lieu of the shortcut's, but I couldn't find any such thing after a quick Google.
IIRC from my old DOS days, you want something like this:

cd /d %~dp0
"%~dp0TCE.xlsm"
exit

Is there no <code> formatting in here, BTW? I can look later but anything beyond that would probably need a decent code tag.

Edit2: Made a batch file and tested it on my WIn8.1 system. That works perfectly and even closes the command line window when done. I had to put quotes around it because my path has spaces. I'd suggest leaving them for everyone, since it doesn't hurt to have them if you don't have spaces in your TCE path but won't work without quotes if you do. When you do a shortcut to the Desktop for that .bat file and add the RunAsAdmin flag, it just prompts for admin access. My UAC settings are bog standard; this system is intentionally left as-is without any tweaks because I use it to develop steps for clients.

Edit3: One thing to note. The variable %~dp0 is the path of the current file including a trailing backslash. Make sure you don't add one between it and the TCE.xlsm in the second line or you'll get a file not found error that you may not even see, since the window just closes after that.
 
Last edited:
is it intended that when you manually select a position, then open the dest. panel the distance is relative to your actual position, not the position you selected by hand?
trying to use this way for manually planning a trade route, but it doesn't seem to work out.
any suggestions on this? is there a way to plan multi hops til the route planner hits?
 
Edit3: One thing to note. The variable %~dp0 is the path of the current file including a trailing backslash. Make sure you don't add one between it and the TCE.xlsm in the second line or you'll get a file not found error that you may not even see, since the window just closes after that.

I actually did try using %~dp0 with an extra backslash (shouldn't matter since it's still a legit path), but it used the dir my shortcut was in rather than the dir of the original batch.
 
is it intended that when you manually select a position, then open the dest. panel the distance is relative to your actual position, not the position you selected by hand?
trying to use this way for manually planning a trade route, but it doesn't seem to work out.
any suggestions on this? is there a way to plan multi hops til the route planner hits?

Ups, yes, i see it too and was corrected here for the next update.

IIRC from my old DOS days, you want something like this:



Is there no <code> formatting in here, BTW? I can look later but anything beyond that would probably need a decent code tag.

Edit2: Made a batch file and tested it on my WIn8.1 system. That works perfectly and even closes the command line window when done. I had to put quotes around it because my path has spaces. I'd suggest leaving them for everyone, since it doesn't hurt to have them if you don't have spaces in your TCE path but won't work without quotes if you do. When you do a shortcut to the Desktop for that .bat file and add the RunAsAdmin flag, it just prompts for admin access. My UAC settings are bog standard; this system is intentionally left as-is without any tweaks because I use it to develop steps for clients.

Edit3: One thing to note. The variable %~dp0 is the path of the current file including a trailing backslash. Make sure you don't add one between it and the TCE.xlsm in the second line or you'll get a file not found error that you may not even see, since the window just closes after that.

Here is a code snippet, that creates both batch files from the installer with the correct path:
ECHO @echo off >> TCE\TCE.bat
ECHO "%~dp0TCE.xlsm" >> TCE\TCE.bat
ECHO @echo off >> TCE\TCE_setup.bat
ECHO "%~dp0TCE_setup.xlsm" >> TCE\TCE_setup.bat
 
Last edited:
I actually did try using %~dp0 with an extra backslash (shouldn't matter since it's still a legit path), but it used the dir my shortcut was in rather than the dir of the original batch.
Did you apply it to the shortcut's command line? That variable pulls whatever the containing file's location happens to be. It absolutely does matter, BTW, if you add a backslash. Doing "%~dp0\ETC.xslm" gives you, say, "X:\Elite\ETC\\ETC.xslm", which is invalid. Using "%~dp0ETC.xslm" will give you the actual path including backslash so it ends up being equivalent to "X:\Elite\ETC\ETC.xslm". If you don't use quotes and have, say an foldername of Elite Dangerous then you'd get X:\Elite\\ETC.xslm. Using quotes in that case would give you "X:\Elite Dangerous\ETC\ETC.xslm".

It's rather nonintuitive, I know, but that's how it works. When I worked at Microsoft, it was one of my most common issues when some enterprise guy would have a failed script and just couldn't figure out where it died. It got to a point where I'd ask if they were using it and if they didn't know, I had them search for it in the script. Heh.
 
Sorry if this has been asked before, I searched the thread but could not find anything.

For some reason TCE does not display my current position anymore. The panel only shows a star system and a sector. It started when I visited a station in the same system I had previously been in. The version I was using at this point was 1.39.

TCE itself is not reporting any errors. However, when starting a new instance of Excel with TCE running I get the following error message:
Error in Position_Display
Error Line: 10
POS ID: 0 DES ID: 0
Unregistered: False
Error (9): Subscript out of range

Now here's what I have tried to fix it so far, without any success
1) upgraded 1.39f (including unblocking and all) -> same problem
2) cleared netlog folders and ran TCE again -> no luck still
3) deleted the entire TCE folder and installed V1.39 (which used to work fine previously) -> still not working
4) deleted netlogs and TCE again, reinstalled and upgraded to V1.39f -> no luck

Nothing of this worked. Any suggestions what might be going on here? It just seems very weird how suddenly the error occurred and how persistent it is, even after a complete reinstall.
Appreciate any help, cheers!

[EDIT] I did not restore my old database after reinstalling. So any database errors should not have been carried over
 
Last edited:
Did you apply it to the shortcut's command line? That variable pulls whatever the containing file's location happens to be. It absolutely does matter, BTW, if you add a backslash. Doing "%~dp0\ETC.xslm" gives you, say, "X:\Elite\ETC\\ETC.xslm", which is invalid. Using "%~dp0ETC.xslm" will give you the actual path including backslash so it ends up being equivalent to "X:\Elite\ETC\ETC.xslm". If you don't use quotes and have, say an foldername of Elite Dangerous then you'd get X:\Elite\\ETC.xslm. Using quotes in that case would give you "X:\Elite Dangerous\ETC\ETC.xslm".

It's rather nonintuitive, I know, but that's how it works. When I worked at Microsoft, it was one of my most common issues when some enterprise guy would have a failed script and just couldn't figure out where it died. It got to a point where I'd ask if they were using it and if they didn't know, I had them search for it in the script. Heh.

I just stuck it in a 1-line batch file that reads "%~dp0TCE.xlsm" (with the quotes, now). It's odd that it's actually working now from a shortcut on the desktop. I could have sworn the previous error I got was that TCE.xlsm didn't reside on the desktop folder. In any case, it works on my PC (Win 8.1) with or without an added \. I definitely think it's the quotes that did the trick. Thanks!
 
Error in EDLog_Read line 10 and 20

Been playing for a while and everything was fine.

Got a Skype call that I knew was going to take a while,
so I parked at a station, Hid TCE and alt-tabbed from ED

when I came back to the game and tried to Un-hide TCE I had these two errors cycling indefinitely :

Error line 10 & 2.jpg

Had to kill Excel with TaskManager.

But everything seems fine again after restarting.
 
Last edited:
eventure, just a small suggestion for a very useful feature (as long as you haven't that covered in your new logbook, that is):

station notes. don't know for what other users use this, but i note available outfitting and ships in there.
when i'm on a trade route or somesuch i think abaout buying x or y.
now i need an option to locate these systems i added notes for.
so, is there a way like you did with the 'large station' thingy to add a checkbox or somesuch
for highlighting stations in the destination panel which have station notes?
this would be very handy, i think.
 
Status
Thread Closed: Not open for further replies.
Back
Top Bottom