I've just finished watching the livestream and I liked everything I saw, except for this clanger. And what a clanger!
Having infinite amounts of 'things' makes no sense whatsoever, and creates a wedge that players will use in other areas of the game. I've already seen posts asking about now getting infinite limpets, infinite weapon ammo, infinite SLFs and infinite SRVs. I'm sure infinite material storage, infinite cargo storage, infinite AMFU ammo, infinite fuel, and infinite jump range will shortly follow.
Frontier employees are on record as saying the infinite ADS range was, in hindsight, a mistake. Here they are repeating the same mistake!
Infinite ammo leaves no room to manoeuvre later on. They should have kept the originally proposed 200 ammo limit for the beta and at least tested how that worked, before making any decision to go infinite.
IMO, the way it should work is this: the ship can perform the equivalent of a probe scan, just by doing an active scan, like a data scan. The 'probe scan' would be centered on the point of the planet closest to the ship. To scan more of the planet surface you would need to fly your ship around to reveal unscanned areas. This is how non-Horizons players would have to do things.
Alternatively, Horizons players would have a limited stash (say 200) of synthesis-replaceable probes that would save them needing to fly around the planet, at the expense of having to gather materials and synthesise new probes every now and then. Horizons players could still choose to play the infinite direct scan.
This retains the 'efficiency target' mini-game, allows for ammo-free infinite scanning, allows for non-Horizons players, but does not introduce the infinite-ammo wedge.