RegulatedNoise - trade tool with zxctypo's best-in-class OCR (EliteOCRReader as-was)

Hi maxh2003 !!!

Very very good tool. I just updated it from 1.5 to 1.8 and i now have a problem.
I play in BORDERLESS 2715X1527 resolution (because of 2 screens, the main one for ED, the other one for RegulatedNoise, Excel, Firefox etc...)
The fact is when i take a screenshot in this resolution with borderless active, the .bmp file is in 1920X1080. (The .bmp is 2715X1527 only when i activate fullscreen).
My problem is that the calibration tool says to me : "The selected image has a different resolution from your current game settings. Do you want to pick another image ?"
I click "No" and go for manual calibration. It could be ok, but the number 12 crosshair never appears so i can't finish calibration. And then i got plenty of mistakes when capturing market data as you can imagine. I guess the last crosshair is out of the picture...
Do i have another solution than playing fullscreen (which oblige me to alt + tab, and well, as i have 2 screens it's a bit too bad to have to do that) ? Can i force a 2715X1725 .bmp whith borderless active ?

Thanks for your very uselfull tool.

Well, i fixed the problem temporarly by moving up the n°12 crosshair on a 2715X1527 .bmp, then i could calibrate a 1920X1080 .bmp correctly. It works almost perfectly except the OCR is less accurate on a 1920X1080 picture and i have to correct more often. But it's ok.
P.S : sorry for my english as it is not my native language, i hope you understood what i meaned^^

I will look into your issue tomorrow, I was sure I put in a failsafe for such, but after it got butchered by maxh2003, maybe it was removed ;)

I had the exact same issue!
 
I tested v1.8 as previously had only ran some very old version.

- at startup it says verboselogging is not set, while it is
- ocr calibration expects .bmp image, you cannot escape with cancel from the file dialog
- needs tradedangerous import.prices file export
- it asks no confirmation, line per line, just dumps everything into the csv.
- palladium buy was 1cr. it must cut off like 1???? remaining four digits completely

In my opinion this is bit odd as it dumps everything into the csv output without asking confirmation line by line. Now this is just fine... if there are no errors, but on my first attempt I got the 1cr instead of 19000cr error in palladium and RN did not ask me to confirm the info in any way. I cant believe its by design that I have to recheck the csv output from the screenshot, in that case I could as easily manually type the stuff.

Am I missing some feature or something?
 
Last edited:
- at startup it says verboselogging is not set, while it is

Very odd, this seems to be working for most people. Please link to your appConfig.xml file and I will investigate.

ocr calibration expects .bmp image

Yep... as it should, I would think?

you cannot escape with canel from the file dialog

Will raise a bug for this.

needs tradedangerous import.prices file export

"Needs" is a strong word! :-D Feature request added.

- it asks no confirmation, line per line, just dumps everything into the csv.

Only if you have Auto-Import turned on.

- palladium buy was 1cr. it must cut off like 1???? remaining four digits completely

This can only be a calibration error, in my experience. I have *never* seen EliteBrainerous do this (return part of the correct answer, but not the whole thing) under normal circumstances. Feel free to post the screenshot and calibration.txt you're using and I can investigate at some point.

RN did not ask me to confirm the info in any way.

Uncheck "Auto Import" if you want to confirm the data...

Am I missing some feature or something?

I'm guessing you've missed the "Edit Results" button at the bottom of the "CSV Output from OCR" box? As long as you have Auto-Import turned off, you can use the Edit Results button to go through the results very quickly, in a separate window where you can compare the original image and the scanned text. It's not dissimilar to the way you correct errors in EliteOCR.

Does that help?
 
Yes helped, thanks!

And the bmp comment was in combination with the cancel not working. For example I had no bmp's in the dir when I ran RN, so I could not escape/continue before I placed bmp (started elite and took a screenshot) in the dir.

BTW stupid question but if a person runs 1920x1080 resolution and has not changed elite FOV settings or anything, should some standard calibration.txt work for him without making one of his own? Its all about pixel coordinates, right?
 
After the update 105 , started RN 1.8 and its not showing anything in Current system

Commodity is all zeros Nothing in station to station


AH restart man I hate code, it works now..:)
 
Last edited:
I had no bmp's in the dir when I ran RN

Yeah, that'd do it! :) GitHub issue #41.

BTW stupid question but if a person runs 1920x1080 resolution and has not changed elite FOV settings or anything, should some standard calibration.txt work for him without making one of his own? Its all about pixel coordinates, right?

Not a stupid question at all. As far as I can tell, for "vanilla" installs of ED, standard calibrations should work. Interestingly, the first version of MRmP's calibration changes worked by taking a set of pre-defined ones for 1920x1080 (or latterly, 2560x1440) and rescaling those calibration points for other resolutions. It was OK but not as perfect as one would hope, hence MRmP reworked it to what you see today.

I do wonder if there is still scope for blending in standard calibrations for stock routines - it would be nice to somehow coordinate the collection of people's calibration.txt files (plus resolution) and average them out... but I haven't really thought this through all that much.

- - - - - Additional Content Posted / Auto Merge - - - - -

After the update 105 , started RN 1.8 and its not showing anything in Current system

Commodity is all zeros Nothing in station to station


AH restart man I hate code, it works now..:)

Interesting and a bit odd. If anyone else finds problems after upgrading to 1.05 please let me know.
 
I had the exact same issue!

Sounds like manual calibration does need a fix. Can you or Warox please post an ED commodities screenshot (at your "unusual" resolution) so I can fix/replicate/test?

OCR1.pngOCR2.png
Here is an example of what the issue is... the app detect that I play the game at 2715x1527, but since I play window bordeless my screenshot are in reality at 1920x1080. So the number 12 calibration is unatainable.... I have to set my game full screen.... take a screenshot... open the app... start calibration... move all the bubble number close to a corner... go back and set the game at window borderless take a screenshot... open the app it then tells me the resolution of my pict is not the same as the game setting but I still use the picture and now I have access to all the bubbles to set the calibration!!!... Maybe have an option to manually set the resolution in that window or have the bubble stack in one corner so we can do it manually that way... the auto calibration does it with the game setting resolution... so when you push a screenie of an other reso you can't calibrate it!
 
First of all thank you very much for this tool.
Unfortunately I have a little problem:
After downloading I checked the file with a virus scanner - and it reported something :eek:
I made further scans and 4 different scanners reported an issue with your program. Results:

Jiangmin Trojan/Rozena.dyn
K7GW DoS-Trojan ( 20036d9f1 )
NANO-Antivirus Trojan.Win32.Agent.djebgp
Symantec WS.Reputation.1

Please respond to that issue.
 
View attachment 8721View attachment 8722
Here is an example of what the issue is... the app detect that I play the game at 2715x1527, but since I play window bordeless my screenshot are in reality at 1920x1080. So the number 12 calibration is unatainable.... I have to set my game full screen.... take a screenshot... open the app... start calibration... move all the bubble number close to a corner... go back and set the game at window borderless take a screenshot... open the app it then tells me the resolution of my pict is not the same as the game setting but I still use the picture and now I have access to all the bubbles to set the calibration!!!... Maybe have an option to manually set the resolution in that window or have the bubble stack in one corner so we can do it manually that way... the auto calibration does it with the game setting resolution... so when you push a screenie of an other reso you can't calibrate it!

My calibration thingy doesnt support the bordless with higher resolutions right yet, I'm working on a fix :)
 
After downloading I checked the file with a virus scanner - and it reported something... Various... Symantec WS.Reputation... Please respond to that issue.

You can find my extensive reply to this issue on page 2 of this thread. Nothing has changed, nor is it likely to. You will have more luck talking to Symantec and the other AVs rather than me because it's literally outside my control.

But no threat is posed to you, and remember, the code is all open source and is available for your inspection at GitHub. if you are genuinely concerned by my binaries, please do download and build RN and EliteBrainerous. But let me save you the time: the compiled python binary for EliteBrainerous will trigger some false positives!
 
Last edited:
First of all thank you very much for this tool.
Unfortunately I have a little problem:
After downloading I checked the file with a virus scanner - and it reported something :eek:
I made further scans and 4 different scanners reported an issue with your program. Results:

Jiangmin Trojan/Rozena.dyn
K7GW DoS-Trojan ( 20036d9f1 )
NANO-Antivirus Trojan.Win32.Agent.djebgp
Symantec WS.Reputation.1

Please respond to that issue.

My ESET NOD 32 finds nothing also running THREAT FIRE ( oldie but a goodie) nothing shows up
 
Sounds like manual calibration does need a fix. Can you or Warox please post an ED commodities screenshot (at your "unusual" resolution) so I can fix/replicate/test?

Hi maxh2003 and others.

Sorry for my late answer as i was very busy and didn't had time for my PC.
I post here the 1920X1080 pic i used for calibration. I had to convert it into jpg to do so. I hope it to be usefull to you. Tell me if you need the original bmp and i'll mail it to you.
Keep doing the awesome work guys !

Screenshot_0017.jpg
 
Missing commodity

In my Suggestion at GIT , spoke of, that BEFORE the images are deleted and before you move on , that RN defaults to the Station Tab so you can see the import, You EYE BALL THE DATA
I just did a run of two systems getting data to set up a trades, check some, but in one system didn't check two/three station ( getting late) & just discovered some commodity are missing it just didn't get imaged, so not imported. I don't know for sure as the images are gone.!
ERROR checking needs to be happening I think this is important to do, either by the Stations Tab opening after import, as the default , and also a count of commodity, like what station has 12 commodity , numbers on the side would help (for coding) if < 20 , BEEP WARNING
Also If the Stations Tab mirrored the basic commodity list as you see in the station this would help also, as we all know how their listed

Other than that RN its going well , so well in fact I got lazy :)
 
this may have already been posted but how do i edit a price in program that has already been OCR'd please?

some of the prices it is auto importing are wrong like daniel station domestic appliances always OCR's at 45 to buy when they are 454
 
this may have already been posted but how do i edit a price in program that has already been OCR'd please?

some of the prices it is auto importing are wrong like daniel station domestic appliances always OCR's at 45 to buy when they are 454

Find the data in either the "By Station" or "By Commodity" tab, then use the "Edit Row" or "Delete Row" buttons at the bottom-right of the window... :)
 
Last edited:
Back
Top Bottom