Abandoned [RELEASE] Trade Computer Extension

[eventure]

Some Feedback:
- SLI switched off -> no change, in any test scenario.
- Office reinstalled -> slight changes in the problem, but still a problem (see below).

so I continued to play some more and found two issues:

1. Issue:
I have a native screen res of 3840x2160 (4k Screen) and also using htis for OS desktop. In-game I set the resulution to 2560x1440 as the native res is to much for my outdated SLI cards.
In a borderless window the OS resulution remains, but the game (or the OS, or the GFX driver, I don't know) scales it up to a full screen window. So we have a logical in-game resolution of 2560x1440, but still a 4k fullscreen window for the OS. That has the effect, that the function "GetWindowRect" in the below code returns the OS window resultion (3840x2160), instead of the logical in-game resultion.
I'm not sure what is the real reason (saving a window which is smaller than the given rect, or if it is really out-of memory), but in any case it results in a "not enough memory" message from the function "stdole.SavePicture".

       If EDRun Then            AppActivate ("Elite - Dangerous (CLIENT)")
            hWnd = FnFindWindowLike("Elite - Dangerous (CLIENT)")
            GetWindowRect hWnd, udtRect
            SetForegroundWindow hWnd
        End If
        If No_Cap = False Then
            stdole.SavePicture hDCToPicture(GetDC(0&), udtRect.Left, udtRect.Top, _
            udtRect.Right - udtRect.Left, udtRect.Bottom - udtRect.Top), BMP_Target
        End If
        If EDRun Then
            AppActivate ("Elite - Dangerous (CLIENT)")
        End If

2. Issue:
Having OS desktop resulotion = in-game resultion makes the problem change:
Both Resolutions = 2560x1440 do work properly, OCR screen scan is perfect.
Both Resolutions = 3840x2160 does result in a black screenshot, but no out of memory message.


So I did myself a workaround for the moment, by adding using SETRES.EXE (freeware tool) and creating batch files, lowering the OS screen res priot to launch ED.
That makes it work, but switching to desktop in game doesn't look nice (but that's not a big issue).

Just came to my mind:
@eventure: I'll try to test, and hardcode my in-game res to the save picture function to see if problem persists.

OK! Maybe not my best idea, as I already failed to start it in debug mode or anything like this.

Thanks for your extensive testing. That is really interesting.
The out of memory is clear, because the big picture doesn't fit into the smaller range. But why UHD making such an issue, is unknown to me.
Your workaround is clever. I will add this to the FAQs.

 

[Conehead]

@Eventure: short question. Would it be possible, to add the EliteOCR call string into INI file?
Something like:

OCRCall=EliteOcrCmd.exe -i Screenshot.bmp -o export.csv -l eng -t

or something similar?

This would allow us to use an alternative tool or batchjob prior execution of EliteOCR.

 

[Conehead]

@Eventure: short question. Would it be possible, to add the EliteOCR call string into INI file?
Something like:

OCRCall=EliteOcrCmd.exe -i Screenshot.bmp -o export.csv -l eng -t

or something similar?

This would allow us to use an alternative tool or batchjob prior execution of EliteOCR.

Maybe I have to explain. I still have problems with the "not enough memory" message. The GetWindowRect returns sometimes native resolution even if I switch Desktop to lower res. No clue why. Means my workaround did not work properly.

I did the following now: when the error pops up, I switch to debug mode and changed the "EliteOCRCmd.exe" to "EliteOCRCmd.bat" and saved this version.
Then I created a matching batch file, which copies a screenshot from the Elite Sreenshot Directory to TCE direcrtory, and then calls EliteOCR the same way as in your code.

In TCE I switched of screenshot in Options.

Result: i can make a manual screenshot by F10 in ED, then hit scan button in TCE and everything is working fine. This seem to work pretty stable.

The only disadvantage is, that I have to edit TCE code (which I can do only, after an error and switching into debug mode). For now that is OK, but with an INI entry I could avoid that for future versions.

 

[eventure]

Maybe I have to explain. I still have problems with the "not enough memory" message. The GetWindowRect returns sometimes native resolution even if I switch Desktop to lower res. No clue why. Means my workaround did not work properly.

I did the following now: when the error pops up, I switch to debug mode and changed the "EliteOCRCmd.exe" to "EliteOCRCmd.bat" and saved this version.
Then I created a matching batch file, which copies a screenshot from the Elite Sreenshot Directory to TCE direcrtory, and then calls EliteOCR the same way as in your code.

In TCE I switched of screenshot in Options.

Result: i can make a manual screenshot by F10 in ED, then hit scan button in TCE and everything is working fine. This seem to work pretty stable.

The only disadvantage is, that I have to edit TCE code (which I can do only, after an error and switching into debug mode). For now that is OK, but with an INI entry I could avoid that for future versions.

I understood your request, but as I said in my last Dev Update, only bugfixes are addressed actually. My resources are directed on the next project, so my time is limited. Next weekend, I will release the last full version with some bugfixes and an updated language file.

Because you know, how to adjust TCE for your purpose, I will tell you, how to access the code easyly without waiting on a debug message.

To make Excel visible after starting, click on the name of this app at the top-left corner. Excel become now visible at your taskbar. Click on it and to open the VBA-Editor, press ALT-F11. Click thereafter on the filled square at the toolbar, below the menubar. TCE is now deactivated.

Open the "DB_Import" modul and change it to your purpose. Thereafter open the "Ablauf_Startprozedur"" and click into the "Release_Setup" subroutine and then click on the filled triangle at the toolbar.
Save TCE and your version is now moodified with your changes.

Otherwise you can open the TCE.xlsm file with the "Disable all Macro" setting of the Excel options. Open the VBA-Editor with ALT-F11 and do the same changes described above.

 

[Conehead]

I understood your request, but as I said in my last Dev Update, only bugfixes are addressed actually. My resources are directed on the next project, so my time is limited. Next weekend, I will release the last full version with some bugfixes and an updated language file.

Because you know, how to adjust TCE for your purpose, I will tell you, how to access the code easyly without waiting on a debug message.

To make Excel visible after starting, click on the name of this app at the top-left corner. Excel become now visible at your taskbar. Click on it and to open the VBA-Editor, press ALT-F11. Click thereafter on the filled square at the toolbar, below the menubar. TCE is now deactivated.

Open the "DB_Import" modul and change it to your purpose. Thereafter open the "Ablauf_Startprozedur"" and click into the "Release_Setup" subroutine and then click on the filled triangle at the toolbar.
Save TCE and your version is now moodified with your changes.

Otherwise you can open the TCE.xlsm file with the "Disable all Macro" setting of the Excel options. Open the VBA-Editor with ALT-F11 and do the same changes described above.

OK, that is absolutely fine and acceptable for me and big thanks for the hints.
As I got more in touch with TCE now, I can say that it is a great app and a very good concept. I like it very much.
Good luck with the migration. Already waiting for the dot.net version.

 

[ron330]

having a issue with the route planner i have everything setup my route planned but it will not let me save the route i mouse over the save button and nothing happens when i click it all the stations have the check marks saying the route is complete

 

[Plaidygami]

This is one of those things that should have been in the game but instead had to be modded in.

Seriously, though, wonderful tool. Thank you.

 

[eventure]

having a issue with the route planner i have everything setup my route planned but it will not let me save the route i mouse over the save button and nothing happens when i click it all the stations have the check marks saying the route is complete

Could you provide a screenshot from your Route Planner panel, when the issue happen?

 

[Jontron]

Ok, that issue has resolved it self I tinkered with my FOV and it seems to work perfectly fine when I slide the slider all the way to the right (i had the FOV set to aprox 56 from the config file but oh well). Now I have another issue as this happens every time i attempt it and the error message is always the same. Under the "find best buy/sell route" from the trade menu, if i were to click on any of the tabs such as station, distance, price or stock the panels lock up and I receive an error stating "runtime error '9' subscript out of range". It was a pain in the butt since the panels freeze and i cant move them but I was able to enter debug mode and saw that this segment of code highlighted "vntBuffer = vntArray ( (lngLbound + lngUbound) / 2, intSortColumn)". The only way I can terminate Excel is from the task manager. I do appreciate all the help. Thanks again!
-JT

Hello again, just popping in to tell you that this bug is still occurring with 1.54.8

 

[kellakind]

still only possible with microsoft excel?

 

[Grumpy181155]

Hi Eventure.
I have found a small problem in your database. I just flew into a previously uncharted system DQ Tucanae and in the reference stars that were suggested was Dalat2. There is no Dalat2 system.

 

[eventure]

Hello again, just popping in to tell you that this bug is still occurring with 1.54.8

Thanks for posting again. Can you please send me your whole database folder, so I can recreate it to eventure(at)ki.tng.de or upload it. Thanks

still only possible with microsoft excel?

Working on a .net version at the moment. See Development Update under News.

Hi Eventure.
I have found a small problem in your database. I just flew into a previously uncharted system DQ Tucanae and in the reference stars that were suggested was Dalat2. There is no Dalat2 system.

Thanks for finding a dud. Will change it for the next release.

 

[Starender]

This looks awesome, you should do a quick video that shows the major features.

 

[adrinker]

This app feels pretty unstable. When I get it open in game, I can use it but after a bit it crashes.

Unfortunately, i'm unable to restart it and it doesn't show as a running process that I need to shut down.

Oh well. back to mining and shooting stuff.

 

[Abil Midena]

Hi Eventure,

I just updated from 1.49 to 1.54.8. Everything went well. I have a question about the new 'star system summary' panel (classic ui).

When entering a system, it used to pop up for 10 sec, then go away. This was great, since my use case is to glance at the notes that give me nav directions on how to approach star ports (e.g. Bob's starport: fly with gal above orbit plane, pop up at 8 Mm) so that I come out of SC aimed directly at the mailslot.

Problem: However, now, regardless of the option "fade in/out star system summary on entry" is checked or not, it never comes up when I enter a star system. I tried it with the check box checked and unchecked, but it never comes up. It does come up if I click on "summary" (classic ui) and it has all my notes etc.

Request: Also, since I use the star system summary 'star system notes' (now shown under 'inner system locations'), even if the panel came up when I entered a star system, I'd have to mouse over and click on the 'star system notes' icon to see my notes. I'd rather it default to those notes when it comes up, but I realize others may want the space stations list / stored locations to be the default. Is there a way you could add an option, say to the 'panel configuration options', where we could choose which comes up? Does that make sense what I am asking?

Thanks,
Abil

 

[eventure]

This looks awesome, you should do a quick video that shows the major features.

I am not good at speaking english, nor at making videos. Someone spoke months ago, he want to make a video, but never heared from him anymore.

This app feels pretty unstable. When I get it open in game, I can use it but after a bit it crashes.

Unfortunately, i'm unable to restart it and it doesn't show as a running process that I need to shut down.

Oh well. back to mining and shooting stuff.

Well, it is stable, but your Office could be not. Most problems of instability came from it. Didn't you saw an Excel process? It should be there and you should be able to kill the process.

Hi Eventure,

I just updated from 1.49 to 1.54.8. Everything went well. I have a question about the new 'star system summary' panel (classic ui).

When entering a system, it used to pop up for 10 sec, then go away. This was great, since my use case is to glance at the notes that give me nav directions on how to approach star ports (e.g. Bob's starport: fly with gal above orbit plane, pop up at 8 Mm) so that I come out of SC aimed directly at the mailslot.

Problem: However, now, regardless of the option "fade in/out star system summary on entry" is checked or not, it never comes up when I enter a star system. I tried it with the check box checked and unchecked, but it never comes up. It does come up if I click on "summary" (classic ui) and it has all my notes etc.

Request: Also, since I use the star system summary 'star system notes' (now shown under 'inner system locations'), even if the panel came up when I entered a star system, I'd have to mouse over and click on the 'star system notes' icon to see my notes. I'd rather it default to those notes when it comes up, but I realize others may want the space stations list / stored locations to be the default. Is there a way you could add an option, say to the 'panel configuration options', where we could choose which comes up? Does that make sense what I am asking?

Thanks,
Abil

It only appears, when the Star System Summary panel is minimized, it will not appear, when it was closed by clicking on the "X" icon.
With the next version, the notebox will be displayed first on star system changes, when it holds some informations.

 

[Abil Midena]

It only appears, when the Star System Summary panel is minimized, it will not appear, when it was closed by clicking on the "X" icon.
With the next version, the notebox will be displayed first on star system changes, when it holds some informations.

Dang it, I was going to try that too. I talked myself out of it. Thank you about the note box.

 

[Thormagog]

Ok, so i got it working, but i have a problem with prices. Let me explain ..

- i visit a new star system, so i add it
- then i dock on a station and add it too
- i open the commodity market and scan first page
- i have to scan a few times, so all of the commodities show up (using 1980x1920 and FOV slider all the way to the left)
- then i manually control prices on the scaned page and if there is something wrong, i correct it
- then i scroll to next page and scan it a few times, to show all available commodities
- I repeat this process until all the data are scanned, then i click SAVE.

And now the fun part - after all data are scanned and saved with manualy corrected values, i click Commodities - View prices and all the data i have corrected are wrong. So the program stores the scanned data and ignores my corrections.

- ok, i think i have to correct them manually from the View prices panel, not Scan prices - so i correct all the values again
- i have to do it 2 times, because when i select Compact view, the prices are again th wrong ones, so i correct them too
- click save and now when i click View prices, they seems OK

- now i click trade
- i search for a commodity, for which i know i did a correction

And guess what .. the old - badly scanned data showed up in Trade panel .. so all my manual work is ignored and i cant use this extension for trading. Am i missing something, or you just cant correct the scanned data?

 

[eventure]

Ok, so i got it working, but i have a problem with prices. Let me explain ..

- i visit a new star system, so i add it
- then i dock on a station and add it too
- i open the commodity market and scan first page
- i have to scan a few times, so all of the commodities show up (using 1980x1920 and FOV slider all the way to the left)
- then i manually control prices on the scaned page and if there is something wrong, i correct it
- then i scroll to next page and scan it a few times, to show all available commodities
- I repeat this process until all the data are scanned, then i click SAVE.

And now the fun part - after all data are scanned and saved with manualy corrected values, i click Commodities - View prices and all the data i have corrected are wrong. So the program stores the scanned data and ignores my corrections.

- ok, i think i have to correct them manually from the View prices panel, not Scan prices - so i correct all the values again
- i have to do it 2 times, because when i select Compact view, the prices are again th wrong ones, so i correct them too
- click save and now when i click View prices, they seems OK

- now i click trade
- i search for a commodity, for which i know i did a correction

And guess what .. the old - badly scanned data showed up in Trade panel .. so all my manual work is ignored and i cant use this extension for trading. Am i missing something, or you just cant correct the scanned data?

Did you pressed the enter key on every change? Only with it, your changes are stored.

 

[Thormagog]

No i didnt, because there was no indication, that i had to (the value changed even without pressing Enter). Ok thanks, i will try it tomorrow.

Btw., what about the different prices between normal / compact view? Shouldnt that only affect the commodities visibility?