Release Elite Dangerous Market Connector (EDMC)

Status
Thread Closed: Not open for further replies.

Athan

Athan
ALEX CAOS said:
installed 3.99.3 allways get the "server down" message, is the server actually down or is a bug too?

edmc gives no server down message
Click to expand...
Do you have any firewall active that might need to allow the 'new' EDMarketConnector.exe to connect out to things? 3.99.3.0 is working fine for me when I hit the 'Update' button (which triggers a CAPI fetch and send to EDDN).
 

ALEX CAOS

ALEX CAOS
sorry postet in wrong thread was ment to be in TCE thread, 3.99.3 runs fine as standalone but i still got the connect error if i use with TCE. I check the firewall later mabe i missed something there. Thank you
 

Athan

Athan
ALEX CAOS said:
sorry postet in wrong thread was ment to be in TCE thread, 3.99.3 runs fine as standalone but i still got the connect error if i use with TCE. I check the firewall later mabe i missed something there. Thank you
Click to expand...
If you happen to be running this all under Linux then there's a known issue with EDMC.py and a check for 'no X11 Display'. We've fixed it in the 'develop' branch. If you're in need I can put out a 3.99.4.0 today. The bug causes EDMC.py to splat out some exceptions to stderr, and I don't know if that would trip up TCE.
 

Athan

Athan
The next full release of EDMC will be 4.0.0.0, which I hope to release early afternoon (UK time) on Monday 13th July 2020.

As well as fixing some bugs and including some other enhancements this will be the big move from Python 2.7 to Python 3.7. So, with that in mind, I'd like as many users as possible to install and test this 3.99.4.0 pre-release to help find any new bugs before that big change is offered to everyone.

You can get it from Pre-Release 3.99.4.0 . Install by simply running it. It's the same as if EDMC offered you a new version and you went through with installing it.
As always, please report any issues on GitHub. If you want to discuss or check anything first then find us in the #edmc channel of the EDCD Discord Server.

Here's the changelog. You should also check my prior post about 3.99.2.0 (3.99.3.0 was just a couple of fixes to the command-line tool EDMC.exe):

Pre-Release 3.99.4.0

Consider this as 'rc1' for the following full '4.0.0.0' release.

  • Properly fix Linux code for when there's no X11 display available. This includes ensuring that the CLI tool EDMC.exe will run without issue, with or without an X11 display.
  • The old 'anonymous' and custom 'uploaderID' options were taken out of the UI back in December 2018, but the settings lingered in the Windows Registry. Thus some users would still have been sending an anonymised or custom 'uploaderID' in EDDN messages with no easy way to de-activate this. The EDDN Relay has been forcefully anonymising uploaderID since March 2018 anyway, so this is redundant. Thus the code that performs this anonymising has now been removed.
  • There used to be an option to output commodities data in 'BPC' format, but the option for this was removed from the UI back in Dec 2016. A few small pieces of code lingered and they have now been removed. Any plugin that was passing COMMODITY_BPC to commodity.export() will now break.
  • There have been general coding style cleanups made to companion.py. No functionality should have changed and cursory checks show no regressions. Please report any weirdness with the automatic checking and upload of commodities data.
 
Last edited:

Athan

Athan
NB: This version is not yet showing up via auto updates or 'Check for Updates...'. I'll make that happen early UK evening time. And I just poked the updates file so this will start to be offered either automatically over the next couple of days, or when you use 'Help' > 'Check for updates'.
Release 4.0.0.0 <- click to download

Developers please note the new Contributing.md, particularly Git branch structure and tag conventions.

  • This release is based on Python 3.7, not 2.7, so a user might find some of their plugins stop working. If you have any plugins that do not have the proper support you'll see a popup about this when you start the program, at most once every 24 hours. As directed on that popup you can check the status of your plugins on 'File' > 'Settings' > 'Plugins' in the new 'Plugins Without Python 3.x Support:' section.

  • New 'Help' > 'About E:D Market Connector' menu item to show the currently running version. Includes a link to the release notes.
  • Translations updated:
    • New languages: Serbian (Latin, Bosnia and Herzegovina), Slovenian (Slovenia) and Swedish.
    • New phrases were added and the only 100% translated languages are now: Czech, French, German, Japanese, Polish, Portugese (Brazil), Portugese (Portugal), Russian, Serbian (Latin), Serbian (Latin, Bosnia and Herzegovina), Spanish, Swedish (Sweden) Ukrainian,
  • EDDB plugin now uses a system's SystemAddress to construct the URL to view the system on eddb.io. This removes the need for the systems.p file. That file will be removed in a future version, plugin authors should not be relying on its presence.
  • EDDB plugin now uses a station's MarketID to construct a URL to view the station on eddb.io. This removes the need for stations.p. That file will be removed in a future version, plugin authors should not be relying on its presence.
  • Tweak to Inara plugin so it will send updates via the Inara API more frequently. Will now send an update, no more often than about once a minute, if your cargo changes at all. This still won't update if you dock and quickly buy or sell some cargo, but it's better than it was before. You can nudge it by waiting a minute then re-opening the Commodities screen, or indeed performing any other action the logs a new Journal event.
  • The old 'anonymous' and custom 'uploaderID' options were taken out of the UI back in December 2018, but the settings lingered in the Windows Registry. Thus some users would still have been sending an anonymised or custom 'uploaderID' in EDDN messages with no easy way to de-activate this.
  • There used to be an option to output commodities data in 'BPC' format, but it was removed from the UI back in Dec 2016. A few small pieces of code lingered and they have now been removed. Any plugin that was passing COMMODITY_BPC to commodity.export() will now break.
  • Fixed a bug where certain combinations of 'Output' and 'EDDN' options would lead to all options on both tabs reverting to their defaults.
  • Fixed a bug where if you copied a Journal file to the live location, resulting in a "Journal.YYMMDDHHMMss.XX - Copy.log" file, the application would pick it up as 'new' and potentially re-send duplicate data to all of EDDN, EDSM and Inara.
  • Fixed the location of Registry keys for the update checker, WinSparkle:
    • To be under the new EDCD Registry key in Computer\HKEY_CURRENT_USER\Software\.
    • To be under EDMarketConnector instead of EDMarketConnector.py inside there.
  • Fixed to throw an exception, rather than a Segmentation Fault, if run on Linux without DISPLAY properly set.
  • Fixed EDMC.exe (command line tool) to correctly report the version with -v.
 
Last edited:

Athan

Athan
And I just poked the updates file so this will start to be offered either automatically over the next couple of days, or when you use 'Help' > 'Check for updates'.
 

Darkman Returns

Darkman Returns
I keep getting a 404 error on EDDB when I click on LHS 20 (System), but the station (Ohm City) opens just fine on EDDB.

https://eddb.io/system/ed-address/115319 is the address that's giving me a 404 error when I click on LHS 20. The correct address on EDDB for that system is https://eddb.io/system/11888. If I delete ed-address/ I do get a system to open up, but it's Col 359 Sector EL-N b24-1 instead.

https://eddb.io/station/18805 is the address when I click on Ohm City and opens up the EDDB page for that station correctly.
 
Last edited:

Athan

Athan
Darkman Returns said:
I keep getting a 404 error on EDDB when I click on LHS 20 (System), but the station (Ohm City) opens just fine on EDDB.

https://eddb.io/system/ed-address/115319 is the address that's giving me a 404 error when I click on LHS 20. The correct address on EDDB for that system is https://eddb.io/system/11888. If I delete ed-address/ I do get a system to open up, but it's Col 359 Sector EL-N b24-1 instead.

https://eddb.io/station/18805 is the address when I click on Ohm City and opens up the EDDB page for that station correctly.
Click to expand...
Is this with EDMC 4.0.0.0 ?

I ask because the 3.99.X.0 series had this bug, due to the Frontier CAPI sometimes returning a system's SystemAddress and sometimes another unrelated ID. What I did to fix this was make EDMC only use the CAPI value if it had none yet, else it only uses the Journal-sourced SystemAddress. So this shouldn't happen with EDMC 4.0.0.0. Well, unless you've run EDMC before entering the game (as is recommended) and hit the 'Update' button for a manual CAPI pull that had a bad SystemAddress in it, but then the moment you get in-game Journal events will correct this.
 
Last edited:

Darkman Returns

Darkman Returns
Yes it was 4.0. I ran EDMC after updating it but everything was greyed out, even the Update button, so I started up the game and EDMC then displayed the information as normal. At that point I clicked on the hyperlinks to test them.
 

Athan

Athan
Darkman Returns said:
Yes it was 4.0. I ran EDMC after updating it but everything was greyed out, even the Update button, so I started up the game and EDMC then displayed the information as normal. At that point I clicked on the hyperlinks to test them.
Click to expand...
OK, I'm going to look at that code again, falling back to by-name EDDB URL if we don't yet have a SystemAddress from the Journal (which we should have had in your scenario!).

This carries the risk of you being in one of the few "same name as another system" systems and EDDB hitting the wrong when in the lookup.

The CAPI data simply can't be relied on for this.
 

Athan

Athan
Darkman Returns said:
Yes it was 4.0. I ran EDMC after updating it but everything was greyed out, even the Update button, so I started up the game and EDMC then displayed the information as normal. At that point I clicked on the hyperlinks to test them.
Click to expand...
I've adjusted the code, and testing looks good (it'll use by-name instead when relying on CAPI data, so will never use a CAPI-supplied SystemAddress), and will put out 4.0.1.0 tomorrow with the fix.
 

Darkman Returns

Darkman Returns
I tested again this morning. I (always start EDMC first by the way and) got the same 404 error when clicking on LHS 20. After starting the game and then clicking on LHS 20 I got the same 404 error. I then clicked on 'Update' on EDMC, then on LHS 20 and this time the correct LHS 20 system page on EDDB opened up.
 

Codger

Codger
Latest version from today (4.0.1.0) no longer works. It comes up, but all my Settings are blank (it's lost my Inara key and EDSM key both), and the Update button is greyed out. The Status menu does nothing. Save Raw Data gives a "Missing Credentials" error. And installing the update deleted the usual icon from both my taskbar and the start menu (I was able to put them back only after rebooting my machine).

I've rebooted, restarted ED, restarted EDMC, and no joy.

Any ideas?

Edit. I restarted my machine again, and ED again, and EDMC again, and suddenly it worked. Strange. Anyway seems to be ok now. So..ignore this post :)
 
Status
Thread Closed: Not open for further replies.
Back
Top Bottom