Abandoned [RELEASE] Trade Computer Extension

bAdbUd · Nov 23, 2015

BUG:

When I got to Logbook and select Activity/Trading I get a run time error, see screenshot for debug info.

I've updated the Station information and scanned all goods, same problem occurs.

A similar issue, different error. I go to Logbook, Activities, Exploration and upon scroll the list I get this error.

In fact just going to the logbook and scrolling up through visited system I get the above error. I get this error 100% of the time and at exactly the same point in the list, as shown in this screenshot.

I'm going to reinstall and recreate db.

That didn't work ^^^^^

Everything has been fine for days, It may be this system or station.

So I'll try another station in this system.

That didn't work ^^^^^

It didn't work for the 1st and 2nd station but at the 4th station in the same system logbook appears to function for adding Activities. But the scroll back issue remains.

Link to db if needed.

===============================

Also I've found 5 more NONE EXISTENT SYSTEMS. For completeness I'll list them all here. Which I've noticed when I import the old db, my 5 which I changed to * NONE EXISTENT SYSTEM X and set coordinates to zero, as I see you have done with 14 and 18804, they get imported with their current names and coordinates, my changes are not included.

These are my changes.

ID	Star Name:	X-Coordinates:	Y-Coordinates:	Z-Coordinates:	SOK:	Note:	Class
14	NONE EXISTENT SYSTEM 1	0	0	0
18804	NONE EXISTENT SYSTEM 2	0	0	0
20614	NONE EXISTENT SYSTEM 3	0	0	0
20608	NONE EXISTENT SYSTEM 4	0	0	0
12282	NONE EXISTENT SYSTEM 5	0	0	0
10994	NONE EXISTENT SYSTEM 6	0	0	0
8566	NONE EXISTENT SYSTEM 7	0	0	0

eventure · Nov 23, 2015

bAdbUd said:
BUG:

When I got to Logbook and select Activity/Trading I get a run time error, see screenshot for debug info.

===============================

Also I've found 5 more NONE EXISTENT SYSTEMS. For completeness I'll list them all here. Which I've noticed when I import the old db, my 5 which I changed to * NONE EXISTENT SYSTEM X and set coordinates to zero, as I see you have done with 14 and 18804, they get imported with their current names and coordinates, my changes are not included.

Hi,

your problem is, that the TCE.mdb and Logbook.mdb database are not coherent, because you have replaced the TCE.mdb from an older backup, but not the Logbook.mdb.
Your TCE.mdb holds 582 Stations, but your Logbook knows about 590 stations. This difference is the problem.
To resolve the issue, please delete at the Logbook.mdb from the Log table the entries with the wrong IDs (sort the StationID column and remove the rows with IDs 583+. That should fix the problem.
Again, if you want to replace your TCE.mdb, you have to replace the all databases, except the Language.mdb and Panel.mdb files.

To let TDM transfer your edited data, you have to set the SOK: value for each entry to 1, don't let it empty.
TDM will transfers your data after the change.

bAdbUd · Nov 23, 2015

Eventure said:
Hi,

your problem is, that the TCE.mdb and Logbook.mdb database are not coherent, because you have replaced the TCE.mdb from an older backup, but not the Logbook.mdb.
Your TCE.mdb holds 582 Stations, but your Logbook knows about 590 stations. This difference is the problem.
To resolve the issue, please delete at the Logbook.mdb from the Log table the entries with the wrong IDs (sort the StationID column and remove the rows with IDs 583+. That should fix the problem.
Again, if you want to replace your TCE.mdb, you have to replace the all databases, except the Language.mdb and Panel.mdb files.

To let TDM transfer your edited data, you have to set the SOK: value for each entry to 1, don't let it empty.
TDM will transfers your data after the change.

I updated my db using the tool, I've never copied it over.

I imported my db and unchecked all the stations at G 141-21 having found them all to invalid from Jan this year. Upon arriving at the first station in said system this problem occurred.

I've still get the scroll back issue, after removing 3 entries in the logbook. How many entries did you see that I should remove?

Anyhow's it's not a problem now, apart from scroll back, and I don't tend to scroll back that much.

Unless you want to clean it up? Although I'd have to send you my latest db, when I stop playing shortly.

Wink Wink .

eventure · Nov 23, 2015

bAdbUd said:
I updated my db using the tool, I've never copied it over.

I imported my db and unchecked all the stations at G 141-21 having found them all to invalid from Jan this year. Upon arriving at the first station in said system this problem occurred.

I've still get the scroll back issue, after removing 3 entries in the logbook. How many entries did you see that I should remove?

Anyhow's it's not a problem now, apart from scroll back, and I don't tend to scroll back that much.

Unless you want to clean it up? Although I'd have to send you my latest db, when I stop playing shortly. Wink Wink .

Ups, yes, removing stations from the database could also create this issue, I did't anticipate that. That have to be adressed.
Will release an update tomorrow.
But for now, you have to clean following entries from the logbook, if you didn't like to wait:

ID	Date	Time	StarID	BodyID	StationID
456	512032	19:26:01	462	26	590
455	512032	19:18:26	462	23	589
452	512032	17:43:35	462	22	588
434	512032	15:24:30	12300	53	587
440	512032	16:06:32	12300	52	586
436	512032	15:50:30	12300	52	586
433	512032	15:10:27	12300	52	586
425	512032	13:35:50	12352	21	585
418	512031	17:57:05	1109	60	584
417	512031	17:48:33	1109	59	583

And from the Activity table:

ID	ActivityCatID	EntryDate	EntryTime	Notes	GoodID	Profit	Missiontype	Kills	StarSystemID	SectorID	PilotName	PilotShipID	Location	StationID
203	7	512032	17:51:56	# TRADE STATION: BENTHAM DOCK ================================= # COMMODITIES: - PALLADIUM 40	1.67	41760	0	0	462	22		0		588
202	7	512032	17:51:39	# TRADE STATION: BENTHAM DOCK ================================= # COMMODITIES: - GOLD ================================= 40	1.27	37360	0	0	462	22		0		588

Activity

That should fix both issues.

bAdbUd · Nov 23, 2015

I suppose if you've been using TCE for over a year, data issues are going to crop up, thanks though, I'll sort those entries.

And I can wait any how's, logging off now.

eventure · Nov 24, 2015

Update (1.55.1) released:

Full-Version 1.55 installer: http://bit.ly/1SBOOU8
Update 1.55.1: http://bit.ly/1N5VLrC (Full-Version 1.55 required)

Changelog:
- Fixed an error with the logbook, if stations were removed from the database by TDM.

Note:
This update didn't need any TDM usage for your database. Copy the content into your TCE folder to update your version.

bAdbUd · Nov 24, 2015

Eventure said:
Update (1.55.1) released:

Full-Version 1.55 installer: http://bit.ly/1SBOOU8

Update 1.55.1: http://bit.ly/1N5VLrC (Full-Version 1.55 required)

Changelog:
- Fixed an error with the logbook, if stations were removed from the database by TDM.

Note:
This update didn't need any TDM usage for your database. Copy the content into your TCE folder to update your version.

You're a star, thank you very muchly

And it works,

scroll back issue resolved.

Maedhros · Nov 24, 2015

Hi Fellow Cmdrs

Back on ED and the forums after a long enforced absence.

Just trying out the 1.55 update Eventure - very slick. I particularly like the way you have updated and implemented the Star System Summary (SSS). Looking forward to your implementation using .Net as well - would this still use MS Access as a database or will you move to SQL/SQLite?

Just a couple of glitches I have noticed though.

Commodity saves
If you remember I had been having a database problem with the price of Indite being changed to the Painite price. I had thought that this was with the database conversion when moving to a new version of TCE but from studying the price scan more closely I see that it is perhaps related to the commodity save routine.

As you will see from below when I input the prices via EliteOCR using a clean scan (I hadn't visited this station before) the Indite price was showing as correct.

I then saved it and immediately viewed the prices and as you will see the price for Indite has changed presumably because of some coding error within the save routine. Strangely though it doesn't happen on every occasion and as yet I have been unable to find a common denominator for those times that an error occurs.

Star System Summary
As I have already said I really like the new SSS particularly as it updates with changes immediately - are there any plans to have a similar immediate update with the cartography module? However when initially starting TCE and using the menu option to show the SSS the menu bar does not show at the bottom.

The only way I have found to achieve this is to open the panels window and then show and hide the SSS. Selecting the SSS from the menu then shows the menu bar as it should.

Also when there are more than 7 or more stations in a system I am unable to use the scroll bar to see any other than the first 6 stations - for some reason the scroll bar does not appear to work.

Dates
Being in the UK I always use the date format dd/mm/yyyy so the US format mm/dd/yyyy is confusing but something I can live with. I have tried messing with my settings to have the UK format in TCE but have been unable to achieve this.

As you will see from the screenshot below TCE appears to mix the formats - is there someway I get get all of them to show my preferred UK option?

Thanks

eventure · Nov 25, 2015

Maedhros said:
Hi Fellow Cmdrs

Back on ED and the forums after a long enforced absence.

Just trying out the 1.55 update Eventure - very slick. I particularly like the way you have updated and implemented the Star System Summary (SSS). Looking forward to your implementation using .Net as well - would this still use MS Access as a database or will you move to SQL/SQLite?

Hi and welcome back.

I preferred using MS Access again, because I know, how to work with. But TCE performing all operations with the databases on SQL commands structure, so Access itself is not required to be installed for using the .net version.
I didn't ever worked with the SQL/SQLite app, I have no experience with it and can't estimate the way, I have to go to transfer the databases. I am working with .net for the first time and decided not to change other parts for the moment.
Perhaps, you can tell me, what improvements we have with a change to SQLite databases?

Maedhros said:
Just a couple of glitches I have noticed though.

Commodity saves
If you remember I had been having a database problem with the price of Indite being changed to the Painite price. I had thought that this was with the database conversion when moving to a new version of TCE but from studying the price scan more closely I see that it is perhaps related to the commodity save routine.

As you will see from below when I input the prices via EliteOCR using a clean scan (I hadn't visited this station before) the Indite price was showing as correct.

View attachment 77461

I then saved it and immediately viewed the prices and as you will see the price for Indite has changed presumably because of some coding error within the save routine. Strangely though it doesn't happen on every occasion and as yet I have been unable to find a common denominator for those times that an error occurs.

View attachment 77462

I checked the routines twice, but can only think of an database problem. I would like to investigate deeper, so could you provide me your database (TCE.mdb)?
If you repeated the steps above at the same station, is the problem reproduceable?

Maedhros said:
Star System Summary
As I have already said I really like the new SSS particularly as it updates with changes immediately - are there any plans to have a similar immediate update with the cartography module?

What data is not up-to-date and when the Cartography panel is missing an update? Could you give me more details on that, thanks.

Maedhros said:
However when initially starting TCE and using the menu option to show the SSS the menu bar does not show at the bottom.

View attachment 77463

The only way I have found to achieve this is to open the panels window and then show and hide the SSS. Selecting the SSS from the menu then shows the menu bar as it should.

Thanks for reporting. This issue happens only with the compact UI. Will be fixed with the next update.

Maedhros said:
Also when there are more than 7 or more stations in a system I am unable to use the scroll bar to see any other than the first 6 stations - for some reason the scroll bar does not appear to work.

View attachment 77464

Found the issue and will be fixed with the next update.

Maedhros said:
Dates
Being in the UK I always use the date format dd/mm/yyyy so the US format mm/dd/yyyy is confusing but something I can live with. I have tried messing with my settings to have the UK format in TCE but have been unable to achieve this.

As you will see from the screenshot below TCE appears to mix the formats - is there someway I get get all of them to show my preferred UK option?

View attachment 77465

Thanks for all screens. The date format will all the same with the next update. It now depends on your local windows date format setting.

bAdbUd · Nov 25, 2015

Maedhros said:
Commodity saves
If you remember I had been having a database problem with the price of Indite being changed to the Painite price. I had thought that this was with the database conversion when moving to a new version of TCE but from studying the price scan more closely I see that it is perhaps related to the commodity save routine.

As you will see from below when I input the prices via EliteOCR using a clean scan (I hadn't visited this station before) the Indite price was showing as correct.

View attachment 77461

I then saved it and immediately viewed the prices and as you will see the price for Indite has changed presumably because of some coding error within the save routine. Strangely though it doesn't happen on every occasion and as yet I have been unable to find a common denominator for those times that an error occurs.

View attachment 77462

I've seen this happen occasionally but haven't paid attention to what caused it, when I've noticed it I've updated the db values to 0 for INDITE. I know that doesn't help much for you Eventure, but it does support CMDR Maedhros report.

I'll try and pay more attention in the future.

bAdbUd · Nov 25, 2015

By the way Eventure the SHIP LOGBOOK is way too awesome. I spend so much time in it updating things. I can't leave a system until I've recorded all Star Classes within my set 17 LY range. That's just one of the things I like about it.

Obviously I like recording data or I wouldn't be using your supper dupper tool. It really does take me back to the reams of paper I had when I first played ELITE on the Spectrum 48k.

I know you're not entertaining feature request just yet, so I'll store them up whilst you concentrate on your .NET version. When you have the .NET version up and running will you be abandoning the MS Office version for updates, fixes and new features?

I'd presume you will be as that'd be a full time day job keeping both up to date.

bAdbUd · Nov 25, 2015

Eventure said:
Hi and welcome back.

I preferred using MS Access again, because I know, how to work with. But TCE performing all operations with the databases on SQL commands structure, so Access itself is not required to be installed for using the .net version.
I didn't ever worked with the SQL/SQLite app, I have no experience with it and can't estimate the way, I have to go to transfer the databases. I am working with .net for the first time and decided not to change other parts for the moment.
Perhaps, you can tell me, what improvements we have with a change to SQLite databases?.

Changing from one db structure to another is not a trivial thing. I've work as a tester fro over 20 years and all of my experiences with data migrations have had untold amount of problems. So I'd say stick with what you know and have.

Example: Working for an ISP, which buys out a competitor, then we have to migrate their data into our data schemas. So many problems.:S

eventure · Nov 25, 2015

bAdbUd said:
By the way Eventure the SHIP LOGBOOK is way too awesome. I spend so much time in it updating things. I can't leave a system until I've recorded all Star Classes within my set 17 LY range. That's just one of the things I like about it.

Obviously I like recording data or I wouldn't be using your supper dupper tool. It really does take me back to the reams of paper I had when I first played ELITE on the Spectrum 48k.

I know you're not entertaining feature request just yet, so I'll store them up whilst you concentrate on your .NET version. When you have the .NET version up and running will you be abandoning the MS Office version for updates, fixes and new features?

I'd presume you will be as that'd be a full time day job keeping both up to date.

The new version should be better in every aspect. It is like a 2.0 version.

bAdbUd said:
Changing from one db structure to another is not a trivial thing. I've work as a tester fro over 20 years and all of my experiences with data migrations have had untold amount of problems. So I'd say stick with what you know and have.

Example: Working for an ISP, which buys out a competitor, then we have to migrate their data into our data schemas. So many problems.:S

Thanks for your point of view on this.

bAdbUd · Nov 26, 2015

What should I do about this?

I noticed in the SMUGGLING list there were 2 OCCUPIED ESCAPE PODS. Then I found COMMERCIAL SAMPLES which are not in the list. So I thought I'll just go to my logbook db and change the duplicate OCCUPIED ESCAPE PODS to COMMERCIAL SAMPLES. Then I found three salvage items all with the same ID?

ID	Salvage
10001	ANCIENT ARTIFACTS
10002	BLACK BOX
10003	EXPERIMENTAL CHEMICALS
10004	MILITARY PLANS
10005	HATCH BREAKER LIMPET CONTROLLER
10006	PROTOTYPE TECH
10007	RARE ARTWORK
10008	REBEL TRANSMISSION
10009	TECHNICAL BLUEPRINTS
10010	TOXIC WASTE
10011	TRADE DATA
10011	OCCUPIED ESCAPE POD
10011	OCCUPIED ESCAPE POD

I've changed the name of the 2nd OCCUPIED ESCAPE POD to COMMERCIAL SAMPLES any way, I'll revert it if I need to.

By the way if you find COMMERCIAL SAMPLES don't bother, GA is 229 and I ain't seen missions for them, useless.

eventure · Nov 26, 2015

bAdbUd said:
What should I do about this?

I noticed in the SMUGGLING list there were 2 OCCUPIED ESCAPE PODS. Then I found COMMERCIAL SAMPLES which are not in the list. So I thought I'll just go to my logbook db and change the duplicate OCCUPIED ESCAPE PODS to COMMERCIAL SAMPLES. Then I found three salvage items all with the same ID?

ID Salvage
10001 ANCIENT ARTIFACTS
10002 BLACK BOX
10003 EXPERIMENTAL CHEMICALS
10004 MILITARY PLANS
10005 HATCH BREAKER LIMPET CONTROLLER
10006 PROTOTYPE TECH
10007 RARE ARTWORK
10008 REBEL TRANSMISSION
10009 TECHNICAL BLUEPRINTS
10010 TOXIC WASTE
10011 TRADE DATA
10011 OCCUPIED ESCAPE POD
10011 OCCUPIED ESCAPE POD

I've changed the name of the 2nd OCCUPIED ESCAPE POD to COMMERCIAL SAMPLES any way, I'll revert it if I need to.

By the way if you find COMMERCIAL SAMPLES don't bother, GA is 229 and I ain't seen missions for them, useless.

Ah, thanks for the info, will correct the list for the next full release comming with the ED 1.5 update.
Change the IDs accordingly.

bAdbUd · Nov 26, 2015

Eventure said:
Ah, thanks for the info, will correct the list for the next full release comming with the ED 1.5 update.
Change the IDs accordingly.

Plus UNKNOWN ARTIFACT needs adding.

Jontron · Nov 27, 2015

Hey there got it working again (supposedly) but TCE is stuck waiting for elite dangerous to start. The game is on when this is happening.

eventure · Nov 27, 2015

Jontron said:
Hey there got it working again (supposedly) but TCE is stuck waiting for elite dangerous to start. The game is on when this is happening.

Did you using the ED 1.5 beta? If so, you have to change the netlog path with the setup.
If not, please start TCE before starting ED.

Jontron · Nov 27, 2015

I am playing on the regulare ED. Not the beta servers. I fixed that issue by changing the paths in the setup, that worked somewhat but when i try to register a station, TCE seems rather slow when i try to use the tab holding the unregistered station tag. i notice that processing is paused in the upper right as well.

bbc743 · Nov 28, 2015

I have got a problem. Maybe someone can help. If i try to scan the wares, OCR windows stays black, this happens if i try detail or update scan. nothing happens. I use TCR 1.55.1, Windows 10, Office 2013. OCR is in the right Folder and i use the latest version 0.7. Any Idears??