Release ED ToolBox - A companion app

Skunkworx · Jun 18, 2017

Alec Turner said:
Yup, I'm seeing the blank windows too. Commenting out the line that runs the new vbs file brings them back again so that's definitely the cause.

// pclose(popen(""" . $vbs_file . """ . " " . """ . $batch_file . """, "r"));

Actually I see the issue. The forum has removed the backslash escape chars from the code I posted. I didn't double check it when I posted the message.

it should look like this:

Code:

pclose(popen("\"" . $vbs_file . "\"" . " " . "\"" . $batch_file . "\"", "r"));

dianne · Jun 19, 2017

Skunkworx said:
Actually I see the issue. The forum has removed the backslash escape chars from the code I posted. I didn't double check it when I posted the message.

it should look like this:

Code:

pclose(popen("\"" . $vbs_file . "\"" . " " . "\"" . $batch_file . "\"", "r"));

Thank you! It appears to be working now, and I haven't seen the error all day

Alec Turner · Jun 19, 2017

Skunkworx said:
Actually I see the issue. The forum has removed the backslash escape chars from the code I posted. I didn't double check it when I posted the message.

it should look like this:

Code:

pclose(popen("\"" . $vbs_file . "\"" . " " . "\"" . $batch_file . "\"", "r"));

Doh! I thought those triple quotes looked weird, should have spotted that. Yup - that seems to have fixed it.

Skunkworx · Jun 19, 2017

That's good news. Hopefully if Walter can test it and likes the solution he might add it to the next release.

Walter Harriman · Jun 19, 2017

Skunkworx said:
I have done a little more work and I think I have come up with a solution. Firstly a taking a look at this post on stack overflow https://stackoverflow.com/questions...c-or-system-in-php-and-do-not-wait-for-output you can see that there is a comment by someone who has has the same issue with php and start with background processing. In the win 10 creators update MS have removed the /B parameter which breaks the current method of launching in the background.

I have found an alternative method of launching a dos batch file in the background (without a popup screen) from php. This can be done via a VBScript. Here is what needs to be modified.

Modify the file EDTB\get\getdata.php at line 152 to read.

Create a new file \bin\UpdateData\runbat.vbs

If it works for everyone else maybe it could be included in the next release.

Nice investigative work [up]

Strife · Jun 19, 2017

Skunkworx said:
That's good news. Hopefully if Walter can test it and likes the solution he might add it to the next release.

You know the source is in github?
Walter is happy for people to pull from the source and then submit a merge request with updates/fixes.

This also goes for anyone who would like to connect EDTB to the Journal

Skunkworx · Jun 19, 2017

Never done github, pull or merge requests. But if it helps I will have a look at it and add this change in.

Walter Harriman · Jun 19, 2017

Skunkworx said:
Never done github, pull or merge requests. But if it helps I will have a look at it and add this change in.

No need in this case since I've already done the changes locally (seems to work btw

). Though in the future using Github would be preferable.

Alec Turner · Jun 20, 2017

Alec Turner said:
Yup - that seems to have fixed it.

OK so no popups but something IS still stealing focus and switching me away from game window, exactly at the moment when I appear in a new system heading towards the star. One emergency stop and overheat later and I've commented the dreaded batch file line out of getdata.php again.

Walter Harriman · Jun 20, 2017

Alec Turner said:
OK so no popups but something IS still stealing focus and switching me away from game window, exactly at the moment when I appear in a new system heading towards the star. One emergency stop and overheat later and I've commented the dreaded batch file line out of getdata.php again.

Argh, that's one annoying problem. I think I'll add an option do disable/enable the auto-update and it will be disabled by default. That way people not running the Creator's update will still be able to use it, and other's will have to update the data the old fashioned way from the tray menu.

Skunkworx · Jun 20, 2017

Alec Turner said:
OK so no popups but something IS still stealing focus and switching me away from game window, exactly at the moment when I appear in a new system heading towards the star. One emergency stop and overheat later and I've commented the dreaded batch file line out of getdata.php again.

That's odd I don't get that behaviour at all. I wonder what the difference is between yours and mine. I run mine with dual monitors and elite in windowed mode. how about you?

Alec Turner · Jun 20, 2017

Skunkworx said:
That's odd I don't get that behaviour at all. I wonder what the difference is between yours and mine. I run mine with dual monitors and elite in windowed mode. how about you?

Single monitor, Elite fullscreen.

dianne · Jun 21, 2017

Skunkworx said:
That's odd I don't get that behaviour at all. I wonder what the difference is between yours and mine. I run mine with dual monitors and elite in windowed mode. how about you?

Alec Turner said:
Single monitor, Elite fullscreen.

I'm also not having this happen; dual monitors, windowed mode

Skunkworx · Jun 21, 2017

dianne said:
I'm also not having this happen; dual monitors, windowed mode

I will try mine in none windowed mode this evening and report what I find. I use windowed mode on mine because it means that it don't have to tab out of elite and I can just move the mouse between the windows.

Skunkworx · Jun 21, 2017

Skunkworx said:
I will try mine in none windowed mode this evening and report what I find. I use windowed mode on mine because it means that it don't have to tab out of elite and I can just move the mouse between the windows.

my brief test showed no difference running mine in windowed mode except the inability to easily move the mouse between the windows without elite minimising. sorry I'm not sure what else to suggest at the moment.

Alec Turner · Jun 22, 2017

Skunkworx said:
my brief test showed no difference running mine in windowed mode except the inability to easily move the mouse between the windows without elite minimising. sorry I'm not sure what else to suggest at the moment.

nevermind, thanks for trying

Zev Woundurlust · Jun 27, 2017

Walter Harriman said:
No need in this case since I've already done the changes locally (seems to work btw ). Though in the future using Github would be preferable.

Does this edit need to be done manually? I just reinstalled EDToolbox and am still getting the cmd.exe popup.

Walter Harriman · Jun 27, 2017

JRohrer said:
Does this edit need to be done manually? I just reinstalled EDToolbox and am still getting the cmd.exe popup.

Yes, since there's no official update to the issue yet. It seems to work for most people so I'll put out an update to EDTB soon™, which will include an option to disable the auto-update from the settings.

Lyvean · Jul 7, 2017

Hey. Just installed this wonderful addon. Any idea though why it always shows the previous system I am in?

Shakhy · Aug 15, 2017

Hi.
When starting ED toolbox, Avast reports it as malware. Also, when jumping to new system, sometimes (usually in populated systems) for a few seconds I cannot control my ship, it seems as if the window in which I run the game gets deselected - I can see mouse cursor appearing and disappearing (could it be because of background data downloads?) I run the game in borderless window. Any help will be appreciated, love the app.