Hi welcome! I would suggest the Xbox controller in the short term, don't spend money on another gamepad, save up for a HOTAS (joystick, throttle, and/or pedals) A lot of people recommend the Saitek X-52 or the CH products. Personally I have a full CH set. Do the searching on these forums, lots of folks have posted their recommendations. Also there a few good Youtube comparison videos out there on various HOTAS for ED and SC.
As for making money, also suggest the search on these forums. Pick up a few local missions, run some trades, build up a little capital, upgrade to carry more trade, etc...
All depends on what you find fun in ED, but trading is the fastest way to make money overall if that is your only goal and don't mind a bit of the grind.